From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41845) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ad0Z7-0005IF-0a for qemu-devel@nongnu.org; Mon, 07 Mar 2016 14:11:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ad0Z6-0000jI-6c for qemu-devel@nongnu.org; Mon, 07 Mar 2016 14:11:36 -0500 References: <1456564857-29160-1-git-send-email-famz@redhat.com> <1456564857-29160-7-git-send-email-famz@redhat.com> From: Max Reitz Message-ID: <56DDD25F.2030903@redhat.com> Date: Mon, 7 Mar 2016 20:11:27 +0100 MIME-Version: 1.0 In-Reply-To: <1456564857-29160-7-git-send-email-famz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="PVhkAiwFlFl2LI5osOwRbAU3rHs3JjHuM" Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v3 06/15] block: Hide HBitmap in block dirty bitmap interface List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Vladimir Sementsov-Ogievskiy , qemu-block@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --PVhkAiwFlFl2LI5osOwRbAU3rHs3JjHuM Content-Type: multipart/mixed; boundary="KDBo0kEpi16kBB665q7PNJcT4U7Q7ktDp" From: Max Reitz To: Fam Zheng , qemu-devel@nongnu.org Cc: Vladimir Sementsov-Ogievskiy , qemu-block@nongnu.org Message-ID: <56DDD25F.2030903@redhat.com> Subject: Re: [Qemu-block] [PATCH v3 06/15] block: Hide HBitmap in block dirty bitmap interface References: <1456564857-29160-1-git-send-email-famz@redhat.com> <1456564857-29160-7-git-send-email-famz@redhat.com> In-Reply-To: <1456564857-29160-7-git-send-email-famz@redhat.com> --KDBo0kEpi16kBB665q7PNJcT4U7Q7ktDp Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 27.02.2016 10:20, Fam Zheng wrote: > HBitmap is an implementation detail of block dirty bitmap that should b= e hidden > from users. Introduce a BdrvDirtyBitmapIter to encapsulate the underlyi= ng > HBitmapIter. >=20 > A small difference in the interface is, before, an HBitmapIter is initi= alized > in place, now the new BdrvDirtyBitmapIter must be dynamically allocated= because > the structure definition is in block.c. >=20 > Two current users are converted too. >=20 > Signed-off-by: Fam Zheng > Reviewed-by: John Snow > --- > block/backup.c | 14 ++++++++------ > block/dirty-bitmap.c | 39 +++++++++++++++++++++++++++++++++---= --- > block/mirror.c | 14 ++++++++------ > include/block/dirty-bitmap.h | 7 +++++-- > include/qemu/typedefs.h | 1 + > 5 files changed, 55 insertions(+), 20 deletions(-) I tried my best at fixing up the rebase conflicts, but block/mirror.c has just changed too much ("mirror: Rewrite mirror_iteration") to be able to pretend these fixes are trivial. Therefore, I'm afraid this patch will need a rebase. Max --KDBo0kEpi16kBB665q7PNJcT4U7Q7ktDp-- --PVhkAiwFlFl2LI5osOwRbAU3rHs3JjHuM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJW3dJfAAoJEDuxQgLoOKytjXgH/i3zilzAJ6Ii6bPlocPayX3Y wkURAdPCJ/ospsoyEqKTmK645nUVnGLvxvBIqhc+eKgZHAIf78ZES5xyF+T/XfGx upC8CKjlAFvsD/tQFjcKMsdFFQ5Cv68X8/0+upNJmz9XxRlw4VTwDbX5ddCE3et3 Ph6Fe9CJh0ls+GAMbzZs333SHEj7Yzw0KtWkadYLXq9dCEQZPbxqzeVAST0wqJo6 kDX8F+6TKSSsa4NSE9/rDKv+8nR8SgZukIU+0loJ9493tAD+sHqAh2R2noQpSALN URuN/kVFa2jlGhS9UZAysKBAaLdVG84ni8Txc0pF/OS9OVbS/ROslqRycotuaUg= =ftvI -----END PGP SIGNATURE----- --PVhkAiwFlFl2LI5osOwRbAU3rHs3JjHuM--