From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50447) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ad2QX-0002jP-T8 for qemu-devel@nongnu.org; Mon, 07 Mar 2016 16:10:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ad2QT-0007SP-BO for qemu-devel@nongnu.org; Mon, 07 Mar 2016 16:10:53 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43904) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ad2QT-0007SL-3N for qemu-devel@nongnu.org; Mon, 07 Mar 2016 16:10:49 -0500 References: <065EA09A-157B-4F3A-BEFC-7C71F8020DC9@gmail.com> <56DB738C.3040204@redhat.com> From: Eric Blake Message-ID: <56DDEE56.60002@redhat.com> Date: Mon, 7 Mar 2016 14:10:46 -0700 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ucCbq7Bim27h9LTCnxLWnC8n814mFBrjV" Subject: Re: [Qemu-devel] [PATCH v3 1/4] adb-keys.h: initial commit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Programmingkid Cc: Peter Maydell , Gerd Hoffmann , qemu-devel qemu-devel This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ucCbq7Bim27h9LTCnxLWnC8n814mFBrjV Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/06/2016 01:35 PM, Programmingkid wrote: >=20 > On Mar 5, 2016, at 7:02 PM, Eric Blake wrote: >=20 >> On 03/04/2016 10:15 PM, Programmingkid wrote: >>> >> >>> + * >>> + * Permission is hereby granted, free of charge, to any person obtai= ning a copy >>> + * of this software and associated documentation files (the "Softwar= e"), to deal >>> + * in the Software without restriction, including without limitation= the rights >>> + * to use, copy, modify, merge, publish, distribute, sublicense, and= /or sell >>> + * copies of the Software, and to permit persons to whom the Softwar= e is >>> + * furnished to do so, subject to the following conditions: >> >> Any reason you chose the weaker BSD license instead of the >> project-default of GPLv2+? >=20 > Could you provide a file name or a link that has the exact text you wis= h to see in the file? BSD is just fine, if you have a strong reason for preferring it (it is a weaker license than GPLv2+, which means GPL code can import BSD code, but BSD code can't import GPL code. Personally, I try to avoid the BSD license on my code, because I don't like the fact that it allows companies to make a proprietary fork of my code, while the GPL guarantees that anyone using my code will keep it free. But other people don't like the GPL and intentionally favor BSD for things they write for maximum uptake of their code.) If you don't have a strong license preference, then there are plenty of GPLv2+ files you can copy from: $ git grep -l 'GPL, version 2 or' | wc -l 482 >=20 >> Can you provide a URL to the source document that you used for coming = up >> with this list, so that we can better double-check your work? (Do it = as >> a comment in this file, if you have one) >=20 > Does this look good: >=20 > /* > * adb-keys.h > * > * Provides an enum of all the Macintosh keycodes. > * Note: keys like Power, volume related, and eject are handled at a l= ower > * level and are not available to QEMU. That doesn't mean we can= 't > * substitute one key for another. The function keys like F1 mak= e a good > * substitute for these keys. This can be done in the GTK, SDL, = or Cocoa > * code. > * Additional information: http://stackoverflow.com/questions/3202629/= where-can > * -i-find-a-list-of-mac-virtual-key-codes The URL is line-broken; but still works (since stackoverflow only cares about the 3202629/ prefix). But yes, that sort of information source is useful as a code comment. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --ucCbq7Bim27h9LTCnxLWnC8n814mFBrjV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJW3e5WAAoJEKeha0olJ0NqOuEH/iR7OOWHPt/aU2gTUJbhyhPY D/p4PzuHYY1tP/G7TtX4PETVNUONa4fEz8zfs3W+CvlGO5Cv6SBC89qr37H0ZcXR H994oYsjwRXJ1H6s/1XmZYDfatwkQC01TvsGW9dZMQ/aXIBwhMm9Hv+Atzxj7W/8 y49TTmaWinmKeFGFhfJmTGevTwwT50xi09sUIFCMgRO47K2kdkDntJrHKnvdRvNm bM3uREdlEW6QWxP6k1XmD9pkgN0bahfN8Q1vdKS3H11Ozk9cd1iClsjCa+4NQlaI KDMLda3RnvHSbbYUhE6KUiQvdHKMKm/00wgFsq0SD79VcdDGMVhL0VpOkxJDi1U= =02vO -----END PGP SIGNATURE----- --ucCbq7Bim27h9LTCnxLWnC8n814mFBrjV--