From: Jason Wang <jasowang@redhat.com>
To: Samuel Thibault <samuel.thibault@gnu.org>
Cc: Thomas Huth <thuth@redhat.com>,
zhanghailiang <zhang.zhanghailiang@huawei.com>,
Li Zhijian <lizhijian@cn.fujitsu.com>,
Stefan Hajnoczi <stefanha@gmail.com>,
Dave Gilbert <dgilbert@redhat.com>,
Vasiliy Tolstov <v.tolstov@selfip.ru>,
qemu-devel@nongnu.org, Gonglei <arei.gonglei@huawei.com>,
Jan Kiszka <jan.kiszka@siemens.com>,
Huangpeng <peter.huangpeng@huawei.com>,
Guillaume Subiron <maethor@subiron.org>
Subject: Re: [Qemu-devel] [PATCHv9 01/10] slirp: Adding IPv6, ICMPv6 Echo and NDP autoconfiguration
Date: Tue, 8 Mar 2016 09:39:20 +0800 [thread overview]
Message-ID: <56DE2D48.7080607@redhat.com> (raw)
In-Reply-To: <20160307112428.GC5169@var.bordeaux.inria.fr>
On 03/07/2016 07:24 PM, Samuel Thibault wrote:
> Jason Wang, on Mon 07 Mar 2016 14:53:54 +0800, wrote:
>>> + switch (ip6->ip_nh) {
>>> +#if 0
>>> + case IPPROTO_TCP:
>>> + tcp_input(m, hlen, (struct socket *)NULL);
>>> + break;
>>> + case IPPROTO_UDP:
>>> + udp_input(m, hlen);
>>> + break;
>>> +#endif
>> This looks odd, why need this?
> To pave the way for the patches after that. We can drop that from this
> patch and move to the other ones if you will, I just believe it makes
> reading this one easier since it explains how tcp and udp will be
> plugged here.
>
> Samuel
This lead warnings in checkpatch, maybe it's better to use comment instead?
next prev parent reply other threads:[~2016-03-08 1:39 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 19:28 [Qemu-devel] [PATCHv9 0/10] slirp: Adding IPv6 support to Qemu -net user mode Samuel Thibault
2016-02-22 19:28 ` [Qemu-devel] [PATCHv9 01/10] slirp: Adding IPv6, ICMPv6 Echo and NDP autoconfiguration Samuel Thibault
2016-03-07 6:53 ` Jason Wang
2016-03-07 11:24 ` Samuel Thibault
2016-03-08 1:39 ` Jason Wang [this message]
2016-02-22 19:28 ` [Qemu-devel] [PATCHv9 02/10] slirp: Adding ICMPv6 error sending Samuel Thibault
2016-03-07 6:55 ` Jason Wang
2016-03-07 13:34 ` Samuel Thibault
2016-02-22 19:28 ` [Qemu-devel] [PATCHv9 03/10] slirp: Adding IPv6 UDP support Samuel Thibault
2016-03-07 6:57 ` Jason Wang
2016-03-07 11:36 ` Samuel Thibault
2016-03-08 1:40 ` Jason Wang
2016-02-22 19:28 ` [Qemu-devel] [PATCHv9 04/10] slirp: Factorizing tcpiphdr structure with an union Samuel Thibault
2016-02-23 8:07 ` Thomas Huth
2016-02-22 19:28 ` [Qemu-devel] [PATCHv9 05/10] slirp: Generalizing and neutralizing various TCP functions before adding IPv6 stuff Samuel Thibault
2016-02-22 19:28 ` [Qemu-devel] [PATCHv9 06/10] slirp: Reindent after refactoring Samuel Thibault
2016-03-07 7:02 ` Jason Wang
2016-03-07 11:38 ` Samuel Thibault
2016-03-08 1:43 ` Jason Wang
2016-02-22 19:28 ` [Qemu-devel] [PATCHv9 07/10] slirp: Handle IPv6 in TCP functions Samuel Thibault
2016-02-22 19:28 ` [Qemu-devel] [PATCHv9 08/10] slirp: Adding IPv6 address for DNS relay Samuel Thibault
2016-02-23 8:12 ` Thomas Huth
2016-02-22 19:28 ` [Qemu-devel] [PATCHv9 09/10] qapi-schema, qemu-options & slirp: Adding Qemu options for IPv6 addresses Samuel Thibault
2016-02-23 8:27 ` Thomas Huth
2016-03-07 7:05 ` Jason Wang
2016-03-07 11:39 ` Samuel Thibault
2016-03-07 11:41 ` Samuel Thibault
2016-03-07 16:05 ` Eric Blake
2016-02-22 19:28 ` [Qemu-devel] [PATCHv9 10/10] slirp: Add IPv6 support to the TFTP code Samuel Thibault
2016-03-04 8:41 ` [Qemu-devel] [PATCHv9 0/10] slirp: Adding IPv6 support to Qemu -net user mode Thomas Huth
2016-03-04 15:50 ` Jan Kiszka
2016-03-06 16:59 ` Samuel Thibault
2016-03-07 5:03 ` Jason Wang
2016-03-07 11:09 ` Samuel Thibault
2016-03-07 12:06 ` Jan Kiszka
2016-03-07 12:11 ` Samuel Thibault
2016-03-07 12:14 ` Thomas Huth
2016-03-07 12:16 ` Jan Kiszka
2016-03-08 2:50 ` Jason Wang
2016-03-08 1:37 ` Jason Wang
2016-03-07 6:48 ` Jason Wang
2016-03-07 11:19 ` Samuel Thibault
2016-03-07 12:00 ` Thomas Huth
2016-03-07 13:37 ` Samuel Thibault
2016-03-08 2:48 ` Jason Wang
2016-03-08 8:53 ` Samuel Thibault
2016-03-07 11:55 ` Samuel Thibault
2016-03-07 15:37 ` Thomas Huth
2016-03-07 16:49 ` Samuel Thibault
2016-03-08 2:15 ` Jason Wang
2016-03-08 9:12 ` Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56DE2D48.7080607@redhat.com \
--to=jasowang@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=dgilbert@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=lizhijian@cn.fujitsu.com \
--cc=maethor@subiron.org \
--cc=peter.huangpeng@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=samuel.thibault@gnu.org \
--cc=stefanha@gmail.com \
--cc=thuth@redhat.com \
--cc=v.tolstov@selfip.ru \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).