From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52358)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1ad6cd-0000PV-El
	for qemu-devel@nongnu.org; Mon, 07 Mar 2016 20:39:40 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1ad6ca-0002HM-9Y
	for qemu-devel@nongnu.org; Mon, 07 Mar 2016 20:39:39 -0500
Received: from mx1.redhat.com ([209.132.183.28]:51375)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1ad6ca-0002HA-3f
	for qemu-devel@nongnu.org; Mon, 07 Mar 2016 20:39:36 -0500
References: <cover.1456168872.git.samuel.thibault@ens-lyon.org>
	<c207eabadb5773311f980365d0814c366c16999f.1456168872.git.samuel.thibault@ens-lyon.org>
	<56DD2582.607@redhat.com> <20160307112428.GC5169@var.bordeaux.inria.fr>
From: Jason Wang <jasowang@redhat.com>
Message-ID: <56DE2D48.7080607@redhat.com>
Date: Tue, 8 Mar 2016 09:39:20 +0800
MIME-Version: 1.0
In-Reply-To: <20160307112428.GC5169@var.bordeaux.inria.fr>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCHv9 01/10] slirp: Adding IPv6,
 ICMPv6 Echo and NDP autoconfiguration
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Samuel Thibault <samuel.thibault@gnu.org>
Cc: Thomas Huth <thuth@redhat.com>, zhanghailiang <zhang.zhanghailiang@huawei.com>, Li Zhijian <lizhijian@cn.fujitsu.com>, Stefan Hajnoczi <stefanha@gmail.com>, Dave Gilbert <dgilbert@redhat.com>, Vasiliy Tolstov <v.tolstov@selfip.ru>, qemu-devel@nongnu.org, Gonglei <arei.gonglei@huawei.com>, Jan Kiszka <jan.kiszka@siemens.com>, Huangpeng <peter.huangpeng@huawei.com>, Guillaume Subiron <maethor@subiron.org>



On 03/07/2016 07:24 PM, Samuel Thibault wrote:
> Jason Wang, on Mon 07 Mar 2016 14:53:54 +0800, wrote:
>>> +    switch (ip6->ip_nh) {
>>> +#if 0
>>> +    case IPPROTO_TCP:
>>> +        tcp_input(m, hlen, (struct socket *)NULL);
>>> +        break;
>>> +    case IPPROTO_UDP:
>>> +        udp_input(m, hlen);
>>> +        break;
>>> +#endif
>> This looks odd, why need this?
> To pave the way for the patches after that. We can drop that from this
> patch and move to the other ones if you will, I just believe it makes
> reading this one easier since it explains how tcp and udp will be
> plugged here.
>
> Samuel

This lead warnings in checkpatch, maybe it's better to use comment instead?