From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52540) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ad6dg-0001cz-JN for qemu-devel@nongnu.org; Mon, 07 Mar 2016 20:40:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ad6dd-0002aL-BH for qemu-devel@nongnu.org; Mon, 07 Mar 2016 20:40:44 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57629) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ad6dc-0002a8-Vj for qemu-devel@nongnu.org; Mon, 07 Mar 2016 20:40:41 -0500 References: <56DD2647.7060003@redhat.com> <20160307113635.GD5169@var.bordeaux.inria.fr> From: Jason Wang Message-ID: <56DE2D8C.8020201@redhat.com> Date: Tue, 8 Mar 2016 09:40:28 +0800 MIME-Version: 1.0 In-Reply-To: <20160307113635.GD5169@var.bordeaux.inria.fr> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCHv9 03/10] slirp: Adding IPv6 UDP support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Samuel Thibault Cc: Thomas Huth , zhanghailiang , Li Zhijian , Stefan Hajnoczi , Dave Gilbert , Vasiliy Tolstov , qemu-devel@nongnu.org, Gonglei , Jan Kiszka , Huangpeng , Guillaume Subiron On 03/07/2016 07:36 PM, Samuel Thibault wrote: > Jason Wang, on Mon 07 Mar 2016 14:57:11 +0800, wrote: >> Part of the codes looks duplicated with ipv4 version. Any chances to >> merge them like tcp? > The duplication is actually quite small: accessing the ip length > is different, filling the address is different, etc. So there are > differences all along the code. Is it really worth the factorization? > It seems to me that it would actually *reduce* lisibility. > > Samuel > I see, so it's ok to leave this patch as is.