From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52863)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1ad6gH-0003Wf-D0
	for qemu-devel@nongnu.org; Mon, 07 Mar 2016 20:43:26 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1ad6gD-0003GA-Jy
	for qemu-devel@nongnu.org; Mon, 07 Mar 2016 20:43:23 -0500
Received: from mx1.redhat.com ([209.132.183.28]:36401)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1ad6gD-0003Fo-Ed
	for qemu-devel@nongnu.org; Mon, 07 Mar 2016 20:43:21 -0500
References: <cover.1456168872.git.samuel.thibault@ens-lyon.org>
	<b11f1bf43d0bbc616a00152f649d85b72a441495.1456168872.git.samuel.thibault@ens-lyon.org>
	<56DD279D.4020404@redhat.com>
	<20160307113816.GE5169@var.bordeaux.inria.fr>
From: Jason Wang <jasowang@redhat.com>
Message-ID: <56DE2E29.6040208@redhat.com>
Date: Tue, 8 Mar 2016 09:43:05 +0800
MIME-Version: 1.0
In-Reply-To: <20160307113816.GE5169@var.bordeaux.inria.fr>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCHv9 06/10] slirp: Reindent after refactoring
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Samuel Thibault <samuel.thibault@gnu.org>
Cc: Thomas Huth <thuth@redhat.com>, zhanghailiang <zhang.zhanghailiang@huawei.com>, Li Zhijian <lizhijian@cn.fujitsu.com>, Stefan Hajnoczi <stefanha@gmail.com>, Dave Gilbert <dgilbert@redhat.com>, Vasiliy Tolstov <v.tolstov@selfip.ru>, qemu-devel@nongnu.org, Gonglei <arei.gonglei@huawei.com>, Jan Kiszka <jan.kiszka@siemens.com>, Huangpeng <peter.huangpeng@huawei.com>, Guillaume Subiron <maethor@subiron.org>



On 03/07/2016 07:38 PM, Samuel Thibault wrote:
> Jason Wang, on Mon 07 Mar 2016 15:02:53 +0800, wrote:
>> On 02/23/2016 03:28 AM, Samuel Thibault wrote:
>>> From: Guillaume Subiron <maethor@subiron.org>
>>>
>>> No code change.
>>>
>>> Signed-off-by: Guillaume Subiron <maethor@subiron.org>
>>> Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
>>> Reviewed-by: Thomas Huth <thuth@redhat.com>
>>> ---
>>>  slirp/tcp_input.c  | 92 +++++++++++++++++++++++++++---------------------------
>>>  slirp/tcp_output.c | 29 +++++++++--------
>>>  slirp/tcp_subr.c   | 50 ++++++++++++++---------------
>> How about other files in slirp/ ?
> What do you mean?  This patch is just meant to reindent the code after
> 'if's and 'case's have been added without reindentation to make it more
> readable.
>
> Do you mean reindenting the whole slirp?  That's quite another work...
>
> Samuel
>

I'm asking since I'm not sure partial reindenting is a the best choice
for us. The patch itself is ok.