From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57348)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1ad7CA-0001Rb-O3
	for qemu-devel@nongnu.org; Mon, 07 Mar 2016 21:16:23 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1ad7C5-00014y-QB
	for qemu-devel@nongnu.org; Mon, 07 Mar 2016 21:16:22 -0500
Received: from mx1.redhat.com ([209.132.183.28]:35998)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1ad7C5-00014o-Kf
	for qemu-devel@nongnu.org; Mon, 07 Mar 2016 21:16:17 -0500
References: <cover.1456168872.git.samuel.thibault@ens-lyon.org>
	<56DD2430.2090509@redhat.com>
	<20160307115508.GJ5169@var.bordeaux.inria.fr>
From: Jason Wang <jasowang@redhat.com>
Message-ID: <56DE35DD.2080000@redhat.com>
Date: Tue, 8 Mar 2016 10:15:57 +0800
MIME-Version: 1.0
In-Reply-To: <20160307115508.GJ5169@var.bordeaux.inria.fr>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCHv9 0/10] slirp: Adding IPv6 support to Qemu
 -net user mode
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Samuel Thibault <samuel.thibault@gnu.org>
Cc: Thomas Huth <thuth@redhat.com>, zhanghailiang <zhang.zhanghailiang@huawei.com>, Li Zhijian <lizhijian@cn.fujitsu.com>, Stefan Hajnoczi <stefanha@gmail.com>, Dave Gilbert <dgilbert@redhat.com>, Vasiliy Tolstov <v.tolstov@selfip.ru>, qemu-devel@nongnu.org, Gonglei <arei.gonglei@huawei.com>, Jan Kiszka <jan.kiszka@siemens.com>, Huangpeng <peter.huangpeng@huawei.com>, Guillaume Subiron <maethor@subiron.org>



On 03/07/2016 07:55 PM, Samuel Thibault wrote:
> Jason Wang, on Mon 07 Mar 2016 14:48:16 +0800, wrote:
>> - the series does not build on w32:
>> In file included from ./slirp/slirp.h:126:0,
>>                  from stubs/slirp.c:3:
>> ./slirp/ip6.h:9:24: fatal error: netinet/in.h: No such file or directory
> Is it the only issue?  Does it build if you add #ifndef _WIN32 around
> that include?

Build works but get some warnings:


slirp/ip6_icmp.c: In function 'icmp6_send_error':
slirp/ip6_icmp.c:84:5: warning: implicit declaration of function
'inet_ntop' [-Wimplicit-function-declaration]
     inet_ntop(AF_INET6, &rip->ip_dst, addrstr, INET6_ADDRSTRLEN);
     ^
slirp/ip6_icmp.c:84:5: warning: nested extern declaration of 'inet_ntop'
[-Wnested-externs]

and

slirp/slirp.c: In function 'slirp_init':
slirp/slirp.c:226:5: warning: implicit declaration of function
'inet_pton' [-Wimplicit-function-declaration]
     inet_pton(AF_INET6, "fec0::0", &slirp->vprefix_addr6);
     ^
slirp/slirp.c:226:5: warning: nested extern declaration of 'inet_pton'
[-Wnested-externs]

(btw, you may refer http://wiki.qemu.org/Hosts/W32 to test this yourself).

>
> Samuel
>