From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33720) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adCTl-000803-3v for qemu-devel@nongnu.org; Tue, 08 Mar 2016 02:54:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1adCTh-0000Np-Qq for qemu-devel@nongnu.org; Tue, 08 Mar 2016 02:54:53 -0500 Received: from e06smtp09.uk.ibm.com ([195.75.94.105]:36095) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adCTh-0000Nh-Fi for qemu-devel@nongnu.org; Tue, 08 Mar 2016 02:54:49 -0500 Received: from localhost by e06smtp09.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 8 Mar 2016 07:54:46 -0000 Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 8B2CE1B08067 for ; Tue, 8 Mar 2016 07:55:09 +0000 (GMT) Received: from d06av05.portsmouth.uk.ibm.com (d06av05.portsmouth.uk.ibm.com [9.149.37.229]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u287sic158720472 for ; Tue, 8 Mar 2016 07:54:44 GMT Received: from d06av05.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av05.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u287shv6006713 for ; Tue, 8 Mar 2016 00:54:43 -0700 References: <1456813104-25902-5-git-send-email-famz@redhat.com> <1457342271-13410-1-git-send-email-famz@redhat.com> <56DDADEE.4020204@linux.vnet.ibm.com> From: Janosch Frank Message-ID: <56DE8543.7040701@linux.vnet.ibm.com> Date: Tue, 8 Mar 2016 08:54:43 +0100 MIME-Version: 1.0 In-Reply-To: <56DDADEE.4020204@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] scripts: Fix dump-guest-memory.py for MemoryRegion.ram_block removal List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Paolo Bonzini , Gonglei , Laszlo Ersek , Peter Xu On 03/07/2016 05:35 PM, Janosch Frank wrote: > On 03/07/2016 10:17 AM, Fam Zheng wrote: >> Signed-off-by: Fam Zheng >> >> --- >> >> This goes after "[PATCH v2 4/7] memory: Drop MemoryRegion.ram_addr" (or >> squashed into it if we want strict synchronization). >> --- >> scripts/dump-guest-memory.py | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/scripts/dump-guest-memory.py b/scripts/dump-guest-memory.py >> index f274bf8..c0a2e99 100644 >> --- a/scripts/dump-guest-memory.py >> +++ b/scripts/dump-guest-memory.py >> @@ -352,7 +352,7 @@ def memory_region_get_ram_ptr(memory_region): >> return (memory_region_get_ram_ptr(memory_region["alias"].dereference()) >> + memory_region["alias_offset"]) >> >> - return qemu_get_ram_ptr(memory_region["ram_addr"] & TARGET_PAGE_MASK) >> + return qemu_get_ram_ptr(memory_region["ram_block"]["offset"]) > > If you get rid of TARGET_PAGE_MASK you might also want to get rid of its > definition, we only use it once. > > I only had a short look, I'll look through your patches tomorrow morning. > > Cheers Didn't see any obvious problems. Thanks for CCing. Cheers >> >> >> def get_guest_phys_blocks(): >> > >