From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>, Peter Xu <peterx@redhat.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 5/8] usb: fix unbounded stack for inotify_watchfn
Date: Tue, 8 Mar 2016 13:22:46 +0100 [thread overview]
Message-ID: <56DEC416.2090506@redhat.com> (raw)
In-Reply-To: <CAFEAcA8U95JAqapvwfZGftKxL_Gd+p742qKqKSOhZX9aKGLryg@mail.gmail.com>
On 08/03/2016 08:20, Peter Maydell wrote:
>> > +#define __BUF_LEN (sizeof(struct inotify_event) + NAME_MAX + 1)
>> > /* From the man page: atleast one event can be read */
>> > - int len = sizeof(struct inotify_event) + NAME_MAX + 1;
>> > int pos;
>> > - char buf[len];
>> > + char buf[__BUF_LEN];
> The commit message subject says this is fixing an unbounded
> stack usage, but (a) this array wasn't unbounded in size
> (b) the change doesn't change the size we allocate.
> What are you trying to do here?
I suspect it's just fixing a false positive in the compiler.
Paolo
next prev parent reply other threads:[~2016-03-08 12:22 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-08 7:00 [Qemu-devel] [PATCH 0/8] Fix several unbounded stack usage Peter Xu
2016-03-08 7:00 ` [Qemu-devel] [PATCH 1/8] qdict: fix unbounded stack for qdict_array_entries Peter Xu
2016-03-08 8:22 ` Markus Armbruster
2016-03-08 10:19 ` Kevin Wolf
2016-03-08 16:21 ` Eric Blake
2016-03-08 16:30 ` Kevin Wolf
2016-03-08 16:50 ` Daniel P. Berrange
2016-03-09 2:57 ` Peter Xu
2016-03-09 3:04 ` Eric Blake
2016-03-09 3:27 ` Peter Xu
2016-03-09 9:48 ` Kevin Wolf
2016-03-09 13:23 ` Markus Armbruster
2016-03-09 13:57 ` Kevin Wolf
2016-03-09 21:03 ` Markus Armbruster
2016-03-10 1:30 ` Peter Xu
2016-03-08 7:00 ` [Qemu-devel] [PATCH 2/8] block: fix unbounded stack for dump_qdict Peter Xu
2016-03-08 8:12 ` Markus Armbruster
2016-03-08 8:53 ` Fam Zheng
2016-03-08 13:47 ` Markus Armbruster
2016-03-09 3:00 ` Peter Xu
2016-03-08 9:31 ` Peter Xu
2016-03-08 13:50 ` Markus Armbruster
2016-03-08 12:17 ` Paolo Bonzini
2016-03-09 3:18 ` Peter Xu
2016-03-08 7:00 ` [Qemu-devel] [PATCH 3/8] usb: fix unbounded stack for ohci_td_pkt Peter Xu
2016-03-08 12:20 ` Paolo Bonzini
2016-03-09 4:59 ` Peter Xu
2016-03-08 7:00 ` [Qemu-devel] [PATCH 4/8] usb: fix unbounded stack for xhci_dma_write_u32s Peter Xu
2016-03-08 7:26 ` Peter Maydell
2016-03-09 5:12 ` Peter Xu
2016-03-08 12:21 ` Paolo Bonzini
2016-03-09 5:08 ` Peter Xu
2016-03-09 7:53 ` Paolo Bonzini
2016-03-09 8:07 ` Peter Xu
2016-03-09 8:34 ` Markus Armbruster
2016-03-09 9:19 ` Peter Xu
2016-03-09 12:52 ` Markus Armbruster
2016-03-09 12:59 ` Paolo Bonzini
2016-03-10 2:07 ` Peter Xu
2016-03-08 7:00 ` [Qemu-devel] [PATCH 5/8] usb: fix unbounded stack for inotify_watchfn Peter Xu
2016-03-08 7:20 ` Peter Maydell
2016-03-08 12:22 ` Paolo Bonzini [this message]
2016-03-09 5:22 ` Peter Xu
2016-03-08 12:22 ` Paolo Bonzini
2016-03-09 5:23 ` Peter Xu
2016-03-08 7:00 ` [Qemu-devel] [PATCH 6/8] usb: fix unbounded stack for usb_mtp_add_str Peter Xu
2016-03-08 8:10 ` Gerd Hoffmann
2016-03-09 5:29 ` Peter Xu
2016-03-08 7:00 ` [Qemu-devel] [PATCH 7/8] migration: fix unbounded stack for source_return_path_thread Peter Xu
2016-03-08 9:48 ` Juan Quintela
2016-03-08 12:27 ` Paolo Bonzini
2016-03-08 12:26 ` Paolo Bonzini
2016-03-09 5:27 ` Peter Xu
2016-03-08 7:00 ` [Qemu-devel] [PATCH 8/8] hw/i386: fix unbounded stack for load_multiboot Peter Xu
2016-03-08 7:17 ` Peter Maydell
2016-03-08 12:29 ` Paolo Bonzini
2016-03-09 5:39 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56DEC416.2090506@redhat.com \
--to=pbonzini@redhat.com \
--cc=kraxel@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).