From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35497) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adGf9-0001pZ-5R for qemu-devel@nongnu.org; Tue, 08 Mar 2016 07:22:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1adGf5-0007kz-3G for qemu-devel@nongnu.org; Tue, 08 Mar 2016 07:22:55 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58094) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adGf4-0007kv-TX for qemu-devel@nongnu.org; Tue, 08 Mar 2016 07:22:51 -0500 References: <1457420446-25276-1-git-send-email-peterx@redhat.com> <1457420446-25276-6-git-send-email-peterx@redhat.com> From: Paolo Bonzini Message-ID: <56DEC416.2090506@redhat.com> Date: Tue, 8 Mar 2016 13:22:46 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 5/8] usb: fix unbounded stack for inotify_watchfn List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , Peter Xu Cc: QEMU Developers , Gerd Hoffmann On 08/03/2016 08:20, Peter Maydell wrote: >> > +#define __BUF_LEN (sizeof(struct inotify_event) + NAME_MAX + 1) >> > /* From the man page: atleast one event can be read */ >> > - int len = sizeof(struct inotify_event) + NAME_MAX + 1; >> > int pos; >> > - char buf[len]; >> > + char buf[__BUF_LEN]; > The commit message subject says this is fixing an unbounded > stack usage, but (a) this array wasn't unbounded in size > (b) the change doesn't change the size we allocate. > What are you trying to do here? I suspect it's just fixing a false positive in the compiler. Paolo