From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42599) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adIqe-0005A7-Rt for qemu-devel@nongnu.org; Tue, 08 Mar 2016 09:42:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1adIqZ-0002iE-PP for qemu-devel@nongnu.org; Tue, 08 Mar 2016 09:42:56 -0500 Received: from mail-qg0-x244.google.com ([2607:f8b0:400d:c04::244]:35148) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adIqZ-0002i5-Kb for qemu-devel@nongnu.org; Tue, 08 Mar 2016 09:42:51 -0500 Received: by mail-qg0-x244.google.com with SMTP id p68so1106168qge.2 for ; Tue, 08 Mar 2016 06:42:51 -0800 (PST) Sender: Richard Henderson References: <1456849468-30217-1-git-send-email-kbastian@mail.uni-paderborn.de> <1456849468-30217-7-git-send-email-kbastian@mail.uni-paderborn.de> <56D5DDC2.4000801@twiddle.net> <56DEA775.9000909@mail.uni-paderborn.de> From: Richard Henderson Message-ID: <56DEE4E6.2030005@twiddle.net> Date: Tue, 8 Mar 2016 09:42:46 -0500 MIME-Version: 1.0 In-Reply-To: <56DEA775.9000909@mail.uni-paderborn.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 6/7] target-tricore: Add cmp.f instruction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bastian Koppelmann , qemu-devel@nongnu.org On 03/08/2016 05:20 AM, Bastian Koppelmann wrote: > On 03/01/2016 07:21 PM, Richard Henderson wrote: >> On 03/01/2016 08:24 AM, Bastian Koppelmann wrote: >>> + >>> + lt = float32_lt_quiet(arg1, arg2, &env->fp_status); >>> + eq = float32_eq_quiet(arg1, arg2, &env->fp_status); >>> + uo = float32_unordered(arg1, arg2, &env->fp_status); >> >> Do it in one step with float32_compare. >> You don't want _quiet; see below re psw_flags. >> > Unfortunately, if I don't use _quiet my tests fail against real hardware... Fail in what way? I don't think _quiet computes all of the bits you need. r~