From: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
To: Richard Henderson <rth@twiddle.net>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 6/7] target-tricore: Add cmp.f instruction
Date: Tue, 8 Mar 2016 16:07:19 +0100 [thread overview]
Message-ID: <56DEEAA7.40709@mail.uni-paderborn.de> (raw)
In-Reply-To: <56DEE4E6.2030005@twiddle.net>
On 03/08/2016 03:42 PM, Richard Henderson wrote:
> On 03/08/2016 05:20 AM, Bastian Koppelmann wrote:
>> On 03/01/2016 07:21 PM, Richard Henderson wrote:
>>> On 03/01/2016 08:24 AM, Bastian Koppelmann wrote:
>>>> +
>>>> + lt = float32_lt_quiet(arg1, arg2, &env->fp_status);
>>>> + eq = float32_eq_quiet(arg1, arg2, &env->fp_status);
>>>> + uo = float32_unordered(arg1, arg2, &env->fp_status);
>>>
>>> Do it in one step with float32_compare.
>>> You don't want _quiet; see below re psw_flags.
>>>
>> Unfortunately, if I don't use _quiet my tests fail against real
>> hardware...
>
> Fail in what way? I don't think _quiet computes all of the bits you need.
For example, if we have arg1 = 0 and arg2 = 0xffffffff then
float32_compare will assert the invalid bit, but the hardware doesn't.
Cheers,
Bastian
next prev parent reply other threads:[~2016-03-08 15:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 16:24 [Qemu-devel] [PATCH 0/7] TriCore FPU patches Bastian Koppelmann
2016-03-01 16:24 ` [Qemu-devel] [PATCH 1/7] target-tricore: Add FPU infrastructure Bastian Koppelmann
2016-03-01 17:46 ` Richard Henderson
2016-03-01 16:24 ` [Qemu-devel] [PATCH 2/7] target-tricore: Move general CHECK_REG_PAIR of decode_rrr_divide Bastian Koppelmann
2016-03-01 17:46 ` Richard Henderson
2016-03-01 16:24 ` [Qemu-devel] [PATCH 3/7] target-tricore: add add.f/sub.f instructions Bastian Koppelmann
2016-03-01 18:10 ` Richard Henderson
2016-03-01 16:24 ` [Qemu-devel] [PATCH 4/7] target-tricore: Add mul.f instruction Bastian Koppelmann
2016-03-01 16:24 ` [Qemu-devel] [PATCH 5/7] target-tricore: Add div.f instruction Bastian Koppelmann
2016-03-01 16:24 ` [Qemu-devel] [PATCH 6/7] target-tricore: Add cmp.f instruction Bastian Koppelmann
2016-03-01 18:21 ` Richard Henderson
2016-03-08 10:20 ` Bastian Koppelmann
2016-03-08 14:42 ` Richard Henderson
2016-03-08 15:07 ` Bastian Koppelmann [this message]
2016-03-08 15:11 ` Bastian Koppelmann
2016-03-08 15:37 ` Richard Henderson
2016-03-08 15:40 ` Bastian Koppelmann
2016-03-01 16:24 ` [Qemu-devel] [PATCH 7/7] target-tricore: Add ftoi and itof instructions Bastian Koppelmann
2016-03-01 18:26 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56DEEAA7.40709@mail.uni-paderborn.de \
--to=kbastian@mail.uni-paderborn.de \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).