From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48591)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kbastian@mail.uni-paderborn.de>) id 1adJEM-00033m-44
	for qemu-devel@nongnu.org; Tue, 08 Mar 2016 10:07:31 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kbastian@mail.uni-paderborn.de>) id 1adJEI-0001GJ-8F
	for qemu-devel@nongnu.org; Tue, 08 Mar 2016 10:07:26 -0500
Received: from mail.uni-paderborn.de ([131.234.142.9]:46149)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kbastian@mail.uni-paderborn.de>) id 1adJEI-0001GF-1e
	for qemu-devel@nongnu.org; Tue, 08 Mar 2016 10:07:22 -0500
References: <1456849468-30217-1-git-send-email-kbastian@mail.uni-paderborn.de>
	<1456849468-30217-7-git-send-email-kbastian@mail.uni-paderborn.de>
	<56D5DDC2.4000801@twiddle.net> <56DEA775.9000909@mail.uni-paderborn.de>
	<56DEE4E6.2030005@twiddle.net>
From: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Message-ID: <56DEEAA7.40709@mail.uni-paderborn.de>
Date: Tue, 8 Mar 2016 16:07:19 +0100
MIME-Version: 1.0
In-Reply-To: <56DEE4E6.2030005@twiddle.net>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 6/7] target-tricore: Add cmp.f instruction
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>, qemu-devel@nongnu.org

On 03/08/2016 03:42 PM, Richard Henderson wrote:
> On 03/08/2016 05:20 AM, Bastian Koppelmann wrote:
>> On 03/01/2016 07:21 PM, Richard Henderson wrote:
>>> On 03/01/2016 08:24 AM, Bastian Koppelmann wrote:
>>>> +
>>>> +    lt = float32_lt_quiet(arg1, arg2, &env->fp_status);
>>>> +    eq = float32_eq_quiet(arg1, arg2, &env->fp_status);
>>>> +    uo = float32_unordered(arg1, arg2, &env->fp_status);
>>>
>>> Do it in one step with float32_compare.
>>> You don't want _quiet; see below re psw_flags.
>>>
>> Unfortunately, if I don't use _quiet my tests fail against real
>> hardware...
> 
> Fail in what way?  I don't think _quiet computes all of the bits you need.

For example, if we have arg1 = 0 and arg2 = 0xffffffff then
float32_compare will assert the invalid bit, but the hardware doesn't.

Cheers,
Bastian