From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43684) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adKOK-0000WG-Gf for qemu-devel@nongnu.org; Tue, 08 Mar 2016 11:21:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1adKOG-0006LS-7D for qemu-devel@nongnu.org; Tue, 08 Mar 2016 11:21:48 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45909) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adKOG-0006LN-0n for qemu-devel@nongnu.org; Tue, 08 Mar 2016 11:21:44 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 9F5BE72096 for ; Tue, 8 Mar 2016 16:21:43 +0000 (UTC) References: <1457420446-25276-1-git-send-email-peterx@redhat.com> <1457420446-25276-2-git-send-email-peterx@redhat.com> <87pov5e5w3.fsf@blackfin.pond.sub.org> <20160308101944.GD5807@noname.str.redhat.com> From: Eric Blake Message-ID: <56DEFC16.6010100@redhat.com> Date: Tue, 8 Mar 2016 09:21:42 -0700 MIME-Version: 1.0 In-Reply-To: <20160308101944.GD5807@noname.str.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xFU9rLCDRGNA5W0poWS5LLqi10NW11Mi2" Subject: Re: [Qemu-devel] [PATCH 1/8] qdict: fix unbounded stack for qdict_array_entries List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , Markus Armbruster Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, Peter Xu , Luiz Capitulino This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --xFU9rLCDRGNA5W0poWS5LLqi10NW11Mi2 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/08/2016 03:19 AM, Kevin Wolf wrote: > Am 08.03.2016 um 09:22 hat Markus Armbruster geschrieben: >> Cc: Kevin, because he added the array in question. >> >> Peter Xu writes: >> >> Unrelated to your patch: I think we've pushed QDict use father than >> sensible. Encoding multiple keys in a string so you can use a flat >> associative array as your catch-all data structure is appropriate in >> AWK, but in C? Not so much... >=20 > We'll always to that, because it's the command line syntax. What you ma= y > criticise is that we convert QAPI objects to the command line > representation instead of the other way around, but changing that (whic= h > I think would be far from trivial, for relatively little use) wouldn't > get rid of this kind of key parsing, but just move it a bit closer to > the command line handling. I actually WANT us to try that conversion (a great GSoC project, if someone wants it) for 2.7. We already did it for SocketAddress, and it makes the code easier to maintain when you can just access foo->data instead of doing qdict_lookup(foo, "data") all over the place. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --xFU9rLCDRGNA5W0poWS5LLqi10NW11Mi2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJW3vwWAAoJEKeha0olJ0Nq95gH/0HicKiARh0TwxlEVtKClWYe U9sCoeWzwyb3GRKw/JdQZPgJi6FKms0mtqJmWaSoJCqxBqABfvyAkFnp7/PliJlt E8Gt4yTxNf05Us8sF4uiNAqjN+rnHa6sTVamZr6Q2CRa0iIrHfjreZ+/e9zGYaQ1 ozcWuFBHUjCPcCTwX3UfQprGpAHrTsSRTPhedQFXH4qXtbTG5B0Kis4F4m1a7jeQ hQDPfou7BqJnMCC7aMfOAq+Jid6HzRUE8jY78SbaKCSGVHiPS7b1cFremJKShTbU DEk7gWh9MoG6rphrkDgqDaHXE1SG0dNH5fPWWtGHZEQgOIPYBpxKd8eTaTb9Few= =Z98B -----END PGP SIGNATURE----- --xFU9rLCDRGNA5W0poWS5LLqi10NW11Mi2--