From: Richard Henderson <rth@twiddle.net>
To: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 1/7] target-tricore: Add FPU infrastructure
Date: Tue, 8 Mar 2016 13:26:10 -0500 [thread overview]
Message-ID: <56DF1942.1080004@twiddle.net> (raw)
In-Reply-To: <1457458958-23933-2-git-send-email-kbastian@mail.uni-paderborn.de>
On 03/08/2016 12:42 PM, Bastian Koppelmann wrote:
> +/* we don't care about input_denormal */
> +static inline uint8_t f_get_excp_flags(CPUTriCoreState *env)
> +{
> + return env->fp_status.float_exception_flags & 0xbf;
> +}
No magic numbers please. It's a long list, but please or all of the named
flags together.
> + if (flags & float_flag_invalid) {
> + env->FPU_FI = (flags & float_flag_invalid) << 31;
> + }
You know that float_flag_invalid is set; you just tested it. Otherwise you're
relying on float_flag_invalid being 1.
You know, you don't have to keep setting these to (1 << 31) either; -1 works
just as well.
r~
next prev parent reply other threads:[~2016-03-08 18:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-08 17:42 [Qemu-devel] [PATCH v2 0/7] TriCore FPU patches Bastian Koppelmann
2016-03-08 17:42 ` [Qemu-devel] [PATCH v2 1/7] target-tricore: Add FPU infrastructure Bastian Koppelmann
2016-03-08 18:26 ` Richard Henderson [this message]
2016-03-08 17:42 ` [Qemu-devel] [PATCH v2 2/7] target-tricore: Move general CHECK_REG_PAIR of decode_rrr_divide Bastian Koppelmann
2016-03-08 17:42 ` [Qemu-devel] [PATCH v2 3/7] target-tricore: add add.f/sub.f instructions Bastian Koppelmann
2016-03-08 18:42 ` Richard Henderson
2016-03-08 17:42 ` [Qemu-devel] [PATCH v2 4/7] target-tricore: Add mul.f instruction Bastian Koppelmann
2016-03-08 18:43 ` Richard Henderson
2016-03-08 17:42 ` [Qemu-devel] [PATCH v2 5/7] target-tricore: Add div.f instruction Bastian Koppelmann
2016-03-08 18:43 ` Richard Henderson
2016-03-08 17:42 ` [Qemu-devel] [PATCH v2 6/7] target-tricore: Add cmp.f instruction Bastian Koppelmann
2016-03-08 18:44 ` Richard Henderson
2016-03-08 17:42 ` [Qemu-devel] [PATCH v2 7/7] target-tricore: Add ftoi and itof instructions Bastian Koppelmann
2016-03-08 18:44 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56DF1942.1080004@twiddle.net \
--to=rth@twiddle.net \
--cc=kbastian@mail.uni-paderborn.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).