From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59315)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1adMag-0003hs-FU
	for qemu-devel@nongnu.org; Tue, 08 Mar 2016 13:42:43 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1adMad-0007Cv-Hy
	for qemu-devel@nongnu.org; Tue, 08 Mar 2016 13:42:42 -0500
Received: from mail-qk0-x241.google.com ([2607:f8b0:400d:c09::241]:32809)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1adMad-0007Cp-DO
	for qemu-devel@nongnu.org; Tue, 08 Mar 2016 13:42:39 -0500
Received: by mail-qk0-x241.google.com with SMTP id q184so781525qkb.0
	for <qemu-devel@nongnu.org>; Tue, 08 Mar 2016 10:42:39 -0800 (PST)
Sender: Richard Henderson <rth7680@gmail.com>
References: <1457458958-23933-1-git-send-email-kbastian@mail.uni-paderborn.de>
	<1457458958-23933-4-git-send-email-kbastian@mail.uni-paderborn.de>
From: Richard Henderson <rth@twiddle.net>
Message-ID: <56DF1D1B.8000700@twiddle.net>
Date: Tue, 8 Mar 2016 13:42:35 -0500
MIME-Version: 1.0
In-Reply-To: <1457458958-23933-4-git-send-email-kbastian@mail.uni-paderborn.de>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 3/7] target-tricore: add add.f/sub.f
	instructions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>, qemu-devel@nongnu.org

On 03/08/2016 12:42 PM, Bastian Koppelmann wrote:
> +    arg1 = float32_squash_input_denormal(arg1, &env->fp_status);               \
> +    arg2 = float32_squash_input_denormal(arg2, &env->fp_status);               \
> +                                                                               \
> +    f_result = float32_##op(arg2, arg1, &env->fp_status);                      \
> +    flags = f_get_excp_flags(env);                                             \
> +    if (flags) {                                                               \

float32_squash_input_denormal is the first thing that float32_##op does.  No 
need to repeat that here.

Otherwise,

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~