From: Eric Blake <eblake@redhat.com>
To: Rita Sinha <rita.sinha89@gmail.com>, qemu-devel@nongnu.org
Cc: Jan Kiszka <jan.kiszka@siemens.com>
Subject: Re: [Qemu-devel] [PATCH 1/2] i386: Prepare for interrupt remapping
Date: Tue, 8 Mar 2016 16:09:52 -0700 [thread overview]
Message-ID: <56DF5BC0.50000@redhat.com> (raw)
In-Reply-To: <56DF5B2A.7070607@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 830 bytes --]
On 03/08/2016 04:07 PM, Eric Blake wrote:
> On 03/08/2016 12:28 PM, Rita Sinha wrote:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> Introduce a DMA default target address space for PCI devices. Catch all
>
> [meta-comment]: When sending a series, both messages should be
> In-Reply-To a 0/2 cover letter, rather than separate top-level threads.
>
> I'll leave review of the patch proper to someone more familiar with the
> code.
Oh, and one more comment:
> Signed-off-by: Rita Sinha <rita.sinha89@gmail.com>
The email claims that 'Jan Kiszka' is the author; if that's true, then
Jan needs to also have an S-o-b. If you are the author instead, then
you should fix your From: attribution.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-03-08 23:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-08 19:28 [Qemu-devel] [PATCH 1/2] i386: Prepare for interrupt remapping Rita Sinha
2016-03-08 23:07 ` Eric Blake
2016-03-08 23:09 ` Eric Blake [this message]
2016-03-10 5:18 ` Peter Xu
2016-03-11 7:27 ` Jan Kiszka
2016-03-14 3:25 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56DF5BC0.50000@redhat.com \
--to=eblake@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
--cc=rita.sinha89@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).