From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53522) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adYvt-0004Rh-5p for qemu-devel@nongnu.org; Wed, 09 Mar 2016 02:53:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1adYvp-0005Ab-VN for qemu-devel@nongnu.org; Wed, 09 Mar 2016 02:53:25 -0500 Received: from mail-wm0-x241.google.com ([2a00:1450:400c:c09::241]:32889) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adYvp-0005AW-P1 for qemu-devel@nongnu.org; Wed, 09 Mar 2016 02:53:21 -0500 Received: by mail-wm0-x241.google.com with SMTP id n186so8518778wmn.0 for ; Tue, 08 Mar 2016 23:53:21 -0800 (PST) Sender: Paolo Bonzini References: <1457420446-25276-1-git-send-email-peterx@redhat.com> <1457420446-25276-5-git-send-email-peterx@redhat.com> <56DEC3E0.1010404@redhat.com> <20160309050812.GK2377@pxdev.xzpeter.org> From: Paolo Bonzini Message-ID: <56DFD66F.9030900@redhat.com> Date: Wed, 9 Mar 2016 08:53:19 +0100 MIME-Version: 1.0 In-Reply-To: <20160309050812.GK2377@pxdev.xzpeter.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/8] usb: fix unbounded stack for xhci_dma_write_u32s List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu Cc: qemu-devel@nongnu.org, Gerd Hoffmann On 09/03/2016 06:08, Peter Xu wrote: > pxdev:bin# gcc -v > Using built-in specs. > COLLECT_GCC=/bin/gcc > COLLECT_LTO_WRAPPER=/usr/libexec/gcc/x86_64-redhat-linux/4.8.5/lto-wrapper > Target: x86_64-redhat-linux > Configured with: ../configure --prefix=/usr --mandir=/usr/share/man --infodir=/usr/share/info --with-bugurl=http://bugzilla.redhat.com/bugzilla --enable-bootstrap --enable-shared --enable-threads=posix --enable-checking=release --with-system-zlib --enable-__cxa_atexit --disable-libunwind-exceptions --enable-gnu-unique-object --enable-linker-build-id --with-linker-hash-style=gnu --enable-languages=c,c++,objc,obj-c++,java,fortran,ada,go,lto --enable-plugin --enable-initfini-array --disable-libgcj --with-isl=/builddir/build/BUILD/gcc-4.8.5-20150702/obj-x86_64-redhat-linux/isl-install --with-cloog=/builddir/build/BUILD/gcc-4.8.5-20150702/obj-x86_64-redhat-linux/cloog-install --enable-gnu-indirect-function --with-tune=generic --with-arch_32=x86-64 --build=x86_64-redhat-linux > Thread model: posix > gcc version 4.8.5 20150623 (Red Hat 4.8.5-4) (GCC) > > Do you know why "might not be inlinable"? Failed to figure it out > myself as mentioned in cover letter.. It's just a difference in compiler versions. But ARRAY_SIZE should be enough to fix it. Paolo