From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39912) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1addeI-0007YE-BL for qemu-devel@nongnu.org; Wed, 09 Mar 2016 07:55:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1addeF-0001ir-1D for qemu-devel@nongnu.org; Wed, 09 Mar 2016 07:55:34 -0500 Received: from mail-wm0-x242.google.com ([2a00:1450:400c:c09::242]:34540) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1addeE-0001ih-QI for qemu-devel@nongnu.org; Wed, 09 Mar 2016 07:55:30 -0500 Received: by mail-wm0-x242.google.com with SMTP id p65so9902300wmp.1 for ; Wed, 09 Mar 2016 04:55:30 -0800 (PST) Sender: Paolo Bonzini References: <1455470231-5223-1-git-send-email-pbonzini@redhat.com> <1455470231-5223-6-git-send-email-pbonzini@redhat.com> <56E01544.6060305@de.ibm.com> From: Paolo Bonzini Message-ID: <56E01D3F.1060204@redhat.com> Date: Wed, 9 Mar 2016 13:55:27 +0100 MIME-Version: 1.0 In-Reply-To: <56E01544.6060305@de.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 5/8] virtio-blk: fix "disabled data plane" mode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christian Borntraeger Cc: qemu-devel@nongnu.org On 09/03/2016 13:21, Christian Borntraeger wrote: > I have some random crashes at startup > > Stack trace of thread 48326: > #0 0x000002aa2e0cce46 bdrv_co_do_rw (qemu-system-s390x) > #1 0x000002aa2e159e8e coroutine_trampoline (qemu-system-s390x) > #2 0x000003ffbc35150a __makecontext_ret (libc.so.6) > > > that I was able to bisect. > commit 2906cddfecff21af20eedab43288b485a679f9ac does crash regularly, > 2906cddfecff21af20eedab43288b485a679f9ac^ does not. > > I will try to find somebody that looks into that - unless you have an idea. The only random idea is to move vblk->dataplane_started = true to the beginning of virtio_blk_data_plane_start rather than the end. Paolo