From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35183)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1adgWV-0002kZ-CR
	for qemu-devel@nongnu.org; Wed, 09 Mar 2016 10:59:44 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1adgWS-0002iC-6X
	for qemu-devel@nongnu.org; Wed, 09 Mar 2016 10:59:43 -0500
Received: from mail-qg0-x243.google.com ([2607:f8b0:400d:c04::243]:36344)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1adgWS-0002i7-21
	for qemu-devel@nongnu.org; Wed, 09 Mar 2016 10:59:40 -0500
Received: by mail-qg0-x243.google.com with SMTP id 14so3419429qgg.3
	for <qemu-devel@nongnu.org>; Wed, 09 Mar 2016 07:59:37 -0800 (PST)
Sender: Richard Henderson <rth7680@gmail.com>
References: <1457520136-5280-1-git-send-email-kbastian@mail.uni-paderborn.de>
	<1457520136-5280-2-git-send-email-kbastian@mail.uni-paderborn.de>
From: Richard Henderson <rth@twiddle.net>
Message-ID: <56E04866.7020607@twiddle.net>
Date: Wed, 9 Mar 2016 10:59:34 -0500
MIME-Version: 1.0
In-Reply-To: <1457520136-5280-2-git-send-email-kbastian@mail.uni-paderborn.de>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 1/7] target-tricore: Add FPU
	infrastructure
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>, qemu-devel@nongnu.org

On 03/09/2016 05:42 AM, Bastian Koppelmann wrote:
> This patch adds a file for all the FPU related helpers with all the includes,
> useful defines, and a function to update the status bits. Additionally it adds
> a mask for the rounding mode bits of PSW as well as all the opcodes for the
> FPU instructions.
>
> Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
> ---
> v2 -> v3:
>      - remove f_get_excp_flags(), which used a magic number

Actually I liked f_get_excp_flags, since it immediately discards the exceptions 
that you don't care about.  I just wanted it to be written

   return get_float_exception_flags(&env->fp_status)
          & (float_flag_invalid
             | float_flag_overflow
             | float_flag_underflow
             | float_flag_output_denormal
             | float_flag_divbyzero
             | float_flag_inexact);

instead of "& 0xbf".

>      - remove double check on float_flag_invalid in f_update_psw_flags()
...
> +    if (flags & float_flag_invalid) {
> +        env->FPU_FI = (flags & float_flag_invalid) << 31;
> +        some_excp = 1;
> +    }

You didn't, actually.


r~