From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53223)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1adhO4-0003uu-4r
	for qemu-devel@nongnu.org; Wed, 09 Mar 2016 11:55:09 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1adhO3-0003rE-Cd
	for qemu-devel@nongnu.org; Wed, 09 Mar 2016 11:55:04 -0500
References: <cover.1457539274.git.berto@igalia.com>
	<8ad83e37ec80ac89ee7a30426c4b0f2c02e033eb.1457539274.git.berto@igalia.com>
From: Max Reitz <mreitz@redhat.com>
Message-ID: <56E0555F.9010704@redhat.com>
Date: Wed, 9 Mar 2016 17:54:55 +0100
MIME-Version: 1.0
In-Reply-To: <8ad83e37ec80ac89ee7a30426c4b0f2c02e033eb.1457539274.git.berto@igalia.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="jkxeViaC2kc8dAsWulbMHLCkoTmTkOK8e"
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 1/4] quorum: Fix crash in
	quorum_aio_cb()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alberto Garcia <berto@igalia.com>, qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--jkxeViaC2kc8dAsWulbMHLCkoTmTkOK8e
Content-Type: multipart/mixed; boundary="MwtE3JpNn6N5CfbMftXlN1fBFWIOxq9Qe"
From: Max Reitz <mreitz@redhat.com>
To: Alberto Garcia <berto@igalia.com>, qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org
Message-ID: <56E0555F.9010704@redhat.com>
Subject: Re: [Qemu-block] [PATCH 1/4] quorum: Fix crash in quorum_aio_cb()
References: <cover.1457539274.git.berto@igalia.com>
 <8ad83e37ec80ac89ee7a30426c4b0f2c02e033eb.1457539274.git.berto@igalia.com>
In-Reply-To: <8ad83e37ec80ac89ee7a30426c4b0f2c02e033eb.1457539274.git.berto@igalia.com>

--MwtE3JpNn6N5CfbMftXlN1fBFWIOxq9Qe
Content-Type: text/plain; charset=iso-8859-15
Content-Transfer-Encoding: quoted-printable

On 09.03.2016 17:11, Alberto Garcia wrote:
> quorum_aio_cb() emits the QUORUM_REPORT_BAD event if there's
> an I/O error in a Quorum child. However sacb->aiocb must be
> correctly initialized for this to happen. read_quorum_children() and
> read_fifo_child() are not doing this, which results in a QEMU crash.
>=20
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> ---
>  block/quorum.c | 12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)

Reviewed-by: Max Reitz <mreitz@redhat.com>

Although I'm wondering whether we could have just used acb->common.bs
instead of sacb->aiocb->bs in quorum_aio_cb(). I guess that sacb->aiocb
is supposed to be equal to &acb->common.

Max


--MwtE3JpNn6N5CfbMftXlN1fBFWIOxq9Qe--

--jkxeViaC2kc8dAsWulbMHLCkoTmTkOK8e
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJW4FVgAAoJEDuxQgLoOKytXQwH/0kE1lyeqNcT9mvYH39FWFiX
FZXmXWwaTOHAjTJGW3wKDHwyNQKCSITspVWBPpDvlGLVyF5WJJNirAamExDkmVn4
uSwjxCBqkyvLlfHSVJe+/897fi3OkcOs2xOwW2N3MtUVMLSfD9jnimTmytA8YUgB
L3wgPBHDrQm9c1+kb77QaN1ZJHe4moVSqCslxoNhota89UwrjEVw+eiJQs+4nkmA
yVqj+3KAZHF0sfyW7U1W6PLedxHEb8ot6N/5r7/a7ATYSRLjsmauaa8CuagZ45L5
z+3ZJeaVZ0Zd5yQnImtLfiGJH0CQsYn566q7X61fb5p6/vi7swrICx7Nma16EIk=
=7Lo3
-----END PGP SIGNATURE-----

--jkxeViaC2kc8dAsWulbMHLCkoTmTkOK8e--