From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36867)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kbastian@mail.uni-paderborn.de>) id 1adhwx-0003OI-Cy
	for qemu-devel@nongnu.org; Wed, 09 Mar 2016 12:31:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kbastian@mail.uni-paderborn.de>) id 1adhwr-0006Ng-Px
	for qemu-devel@nongnu.org; Wed, 09 Mar 2016 12:31:07 -0500
Received: from mail.uni-paderborn.de ([131.234.142.9]:57671)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kbastian@mail.uni-paderborn.de>) id 1adhwr-0006NW-JY
	for qemu-devel@nongnu.org; Wed, 09 Mar 2016 12:31:01 -0500
References: <1457520136-5280-1-git-send-email-kbastian@mail.uni-paderborn.de>
	<1457520136-5280-2-git-send-email-kbastian@mail.uni-paderborn.de>
	<56E04866.7020607@twiddle.net>
From: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Message-ID: <56E05DBF.4060405@mail.uni-paderborn.de>
Date: Wed, 9 Mar 2016 18:30:39 +0100
MIME-Version: 1.0
In-Reply-To: <56E04866.7020607@twiddle.net>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 1/7] target-tricore: Add FPU
 infrastructure
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>, qemu-devel@nongnu.org

On 03/09/2016 04:59 PM, Richard Henderson wrote:
> On 03/09/2016 05:42 AM, Bastian Koppelmann wrote:
>> This patch adds a file for all the FPU related helpers with all the
>> includes,
>> useful defines, and a function to update the status bits. Additionally
>> it adds
>> a mask for the rounding mode bits of PSW as well as all the opcodes
>> for the
>> FPU instructions.
>>
>> Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
>> ---
>> v2 -> v3:
>>      - remove f_get_excp_flags(), which used a magic number
> 
> Actually I liked f_get_excp_flags, since it immediately discards the
> exceptions that you don't care about.  I just wanted it to be written
> 
>   return get_float_exception_flags(&env->fp_status)
>          & (float_flag_invalid
>             | float_flag_overflow
>             | float_flag_underflow
>             | float_flag_output_denormal
>             | float_flag_divbyzero
>             | float_flag_inexact);
> 
> instead of "& 0xbf".

Okay, I see. Thanks for the clarification.

> 
>>      - remove double check on float_flag_invalid in f_update_psw_flags()
> ...
>> +    if (flags & float_flag_invalid) {
>> +        env->FPU_FI = (flags & float_flag_invalid) << 31;
>> +        some_excp = 1;
>> +    }
> 
> You didn't, actually.
> 

Errr.. That was not supposed to happen, sorry.

Cheers,
Bastian