From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42490)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1adiF5-0003B8-4l
	for qemu-devel@nongnu.org; Wed, 09 Mar 2016 12:49:52 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1adiF1-000419-6N
	for qemu-devel@nongnu.org; Wed, 09 Mar 2016 12:49:51 -0500
Received: from mx1.redhat.com ([209.132.183.28]:33318)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1adiF1-000412-1c
	for qemu-devel@nongnu.org; Wed, 09 Mar 2016 12:49:47 -0500
References: <1457544504-8548-1-git-send-email-berrange@redhat.com>
	<1457544504-8548-15-git-send-email-berrange@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <56E06237.3060500@redhat.com>
Date: Wed, 9 Mar 2016 18:49:43 +0100
MIME-Version: 1.0
In-Reply-To: <1457544504-8548-15-git-send-email-berrange@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v1 14/21] char: remove
 qemu_chr_finish_socket_connection method
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: Stefan Weil <sw@weilnetz.de>, Andrew Baumann <Andrew.Baumann@microsoft.com>



On 09/03/2016 18:28, Daniel P. Berrange wrote:
> @@ -3131,7 +3118,9 @@ static bool qemu_chr_open_socket_fd(CharDriverState *chr, Error **errp)
>          if (qio_channel_socket_listen_sync(sioc, s->addr, errp) < 0) {
>              goto fail;
>          }
> -        qemu_chr_finish_socket_connection(chr, sioc);
> +        s->listen_ioc = sioc;
> +        s->listen_tag = qio_channel_add_watch(
> +            QIO_CHANNEL(s->listen_ioc), G_IO_IN, tcp_chr_accept, chr, NULL);
>      } else if (s->reconnect_time) {
>          qio_channel_socket_connect_async(sioc, s->addr,
>                                           qemu_chr_socket_connected,

Aha, yes, this could be it.  If you move WSAEventSelect to
qio_channel_set_blocking, the previous patch will probably become
unnecessary.

Paolo