From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45253)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1adiO3-0001lY-R3
	for qemu-devel@nongnu.org; Wed, 09 Mar 2016 12:59:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1adiO0-0006z4-L2
	for qemu-devel@nongnu.org; Wed, 09 Mar 2016 12:59:07 -0500
Received: from mx1.redhat.com ([209.132.183.28]:33886)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1adiO0-0006z0-FF
	for qemu-devel@nongnu.org; Wed, 09 Mar 2016 12:59:04 -0500
References: <1457544504-8548-1-git-send-email-berrange@redhat.com>
	<1457544504-8548-20-git-send-email-berrange@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <56E06464.1030203@redhat.com>
Date: Wed, 9 Mar 2016 18:59:00 +0100
MIME-Version: 1.0
In-Reply-To: <1457544504-8548-20-git-send-email-berrange@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v1 19/21] osdep: remove use of
 socket_error() from all code
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: Stefan Weil <sw@weilnetz.de>, Andrew Baumann <Andrew.Baumann@microsoft.com>



On 09/03/2016 18:28, Daniel P. Berrange wrote:
> diff --git a/util/oslib-win32.c b/util/oslib-win32.c
> index b8c9cbe..77db075 100644
> --- a/util/oslib-win32.c
> +++ b/util/oslib-win32.c
> @@ -124,13 +124,13 @@ void qemu_set_block(int fd)
>  {
>      unsigned long opt = 0;
>      WSAEventSelect(fd, NULL, 0);
> -    ioctlsocket(fd, FIONBIO, &opt);
> +    ioctl(fd, FIONBIO, &opt);
>  }
>  
>  void qemu_set_nonblock(int fd)
>  {
>      unsigned long opt = 1;
> -    ioctlsocket(fd, FIONBIO, &opt);
> +    ioctl(fd, FIONBIO, &opt);
>      qemu_fd_register(fd);
>  }

These should have been in patch 18, but see my answer to patch 17.

Paolo