From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60679) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adkGT-00061f-Bv for qemu-devel@nongnu.org; Wed, 09 Mar 2016 14:59:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1adkGQ-0002Dv-6E for qemu-devel@nongnu.org; Wed, 09 Mar 2016 14:59:25 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35130) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adkGQ-0002Dr-1P for qemu-devel@nongnu.org; Wed, 09 Mar 2016 14:59:22 -0500 References: <1457544504-8548-1-git-send-email-berrange@redhat.com> <1457544504-8548-13-git-send-email-berrange@redhat.com> <56E061B1.9040706@redhat.com> From: Eric Blake Message-ID: <56E08098.5050403@redhat.com> Date: Wed, 9 Mar 2016 12:59:20 -0700 MIME-Version: 1.0 In-Reply-To: <56E061B1.9040706@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="mTuI9p7oLjGGQaG3wuaWNHOIrCXm20iQA" Subject: Re: [Qemu-devel] [PATCH v1 12/21] io: implement socket watch for win32 using WSAEventSelect+select List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: Stefan Weil , Andrew Baumann This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --mTuI9p7oLjGGQaG3wuaWNHOIrCXm20iQA Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/09/2016 10:47 AM, Paolo Bonzini wrote: > On 09/03/2016 18:28, Daniel P. Berrange wrote: >> From: Paolo Bonzini >=20 > Reviewing my own patch looks weird. :) >=20 >> On Win32 we cannot directly poll on socket handles. Instead we >> create a Win32 event object and associate the socket handle with >> the event. When the event signals readyness we then have to >> use select to determine which events are ready. Creating Win32 >> events is moderately heavyweight, so we don't want todo it >> every time we create a GSource, so this associates a single >> event with a QIOChannel. >> >> Signed-off-by: Daniel P. Berrange >> --- Especially when it lacks your S-o-b :) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --mTuI9p7oLjGGQaG3wuaWNHOIrCXm20iQA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJW4ICYAAoJEKeha0olJ0NqZo8H/1Mg3Je0+7v487k0rmhN9CSQ bWCcgPlKBReffmoFP4fODwPKrl/JPC2zBv5fiA+m1GeTLYqzI+dcc4zpsBCbGHNl UJxGO/zjYKi2Ag+h83YiJFM1tZEG0fHvmnJqa2TNy+4fg6n+axHnFw5bIMWdxur5 AZZKsVW/xo+Lyrp2JnYoq5Z0U15wsxLgY0+ekmGdgwTwVKpx1ax6J7UerdTLGCLR PVgPx5N2tf1pCuFCfKf8agGRRP+/vUqZDzl3I/7y0yGQZsduugBMBuB5u2+4qvHn savljKunaQk2VftBUVDVB9QhtgQuXS/HFp9J2YoCJsu5vc6FY2tKT92bE3q4/+0= =ZUo9 -----END PGP SIGNATURE----- --mTuI9p7oLjGGQaG3wuaWNHOIrCXm20iQA--