From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34967) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adlTz-0002Kv-8d for qemu-devel@nongnu.org; Wed, 09 Mar 2016 16:17:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1adlTv-0002J4-44 for qemu-devel@nongnu.org; Wed, 09 Mar 2016 16:17:27 -0500 References: <1447201710-10229-1-git-send-email-benh@kernel.crashing.org> <1447201710-10229-73-git-send-email-benh@kernel.crashing.org> <56D74D5E.9090307@redhat.com> <56E081E1.5020003@fr.ibm.com> From: Thomas Huth Message-ID: <56E092DE.5040101@redhat.com> Date: Wed, 9 Mar 2016 22:17:18 +0100 MIME-Version: 1.0 In-Reply-To: <56E081E1.5020003@fr.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 72/77] ppc: A couple more dummy POWER8 Book4 regs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , Benjamin Herrenschmidt , qemu-ppc@nongnu.org Cc: qemu-devel@nongnu.org On 09.03.2016 21:04, C=C3=A9dric Le Goater wrote: > On 03/02/2016 09:30 PM, Thomas Huth wrote: >> On 11.11.2015 01:28, Benjamin Herrenschmidt wrote: >>> WORT and PID this time >>> ... >> AFAICT all patches where you define new SPRs with spr_register_kvm[_hv= ] >> are also important independently of the rest of your patch series - >> otherwise these registers are currently lost during migration since th= ey >> are not sync'ed with the KVM part in the kernel right now. >> >> So if you've got some spare time, could you maybe extract all those >> patches that define new SPRs with spr_register_kvm[_hv] and send them = as >> a separate patch series? That could help to fix future migration issue= s, >> and also would decrease the size of your really huge "Add native POWER= 8 >> platform" patch series a little bit! >=20 > I have been maintaining a port of Ben's patchset on the latest qemu for= other=20 > parts which should come after pnv is merged so I have a framework to te= st such=20 > sub-patchsets. I also have time to work on them but clearly not the exp= ertise > in all areas ! That would be great if you could take care of this! > What would be nice is to identify the most obvious ones, non controvers= ial > that could be merged after a few iterations. I have a vague idea, the o= nes=20 > Reviewed-by David obviously being good candidates, the definition of ne= w SPRs=20 > (even the dummy ones ?). I really like to see the KVM SPRs patches first - since they are fixing potential problems with migration of the _current_ KVM machines already! And being bug fixes, maybe these patches could even be included for QEMU 2.6 already? (i.e. before the hard freeze at the end of March) So my wish-list for a first small patch series looks like this: 5b287e66c7513209 ppc: Add macros to register hypervisor mode SPRs 34f1af75e75e7ba0 ppc: Add dummy CIABR SPR 48adf38e9cab4663 ppc: A couple more dummy POWER8 Book4 regs 730a9b4dc9414818 ppc: Add KVM numbers to some P8 SPRs There are a couple of other patches touching the SPRs initialization, but they are not important with regards to migration... so not sure whether it makes sense to include them now already... Thomas