From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36813) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adlbN-0005hw-2w for qemu-devel@nongnu.org; Wed, 09 Mar 2016 16:25:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1adlbJ-00045M-Kf for qemu-devel@nongnu.org; Wed, 09 Mar 2016 16:25:05 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55456) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adlbJ-00044y-F6 for qemu-devel@nongnu.org; Wed, 09 Mar 2016 16:25:01 -0500 References: <1457544504-8548-1-git-send-email-berrange@redhat.com> <1457544504-8548-13-git-send-email-berrange@redhat.com> <56E061B1.9040706@redhat.com> <56E08098.5050403@redhat.com> From: Paolo Bonzini Message-ID: <56E094A3.5010103@redhat.com> Date: Wed, 9 Mar 2016 22:24:51 +0100 MIME-Version: 1.0 In-Reply-To: <56E08098.5050403@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="DwrR9vgEb4JMJnifsOLt9cmRapApiEC8D" Subject: Re: [Qemu-devel] [PATCH v1 12/21] io: implement socket watch for win32 using WSAEventSelect+select List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: Stefan Weil , Andrew Baumann This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --DwrR9vgEb4JMJnifsOLt9cmRapApiEC8D Content-Type: multipart/mixed; boundary="ce0fudUWvXrDVqPMMQHeFAU6Cppq0Galm" From: Paolo Bonzini To: Eric Blake , "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: Stefan Weil , Andrew Baumann Message-ID: <56E094A3.5010103@redhat.com> Subject: Re: [Qemu-devel] [PATCH v1 12/21] io: implement socket watch for win32 using WSAEventSelect+select References: <1457544504-8548-1-git-send-email-berrange@redhat.com> <1457544504-8548-13-git-send-email-berrange@redhat.com> <56E061B1.9040706@redhat.com> <56E08098.5050403@redhat.com> In-Reply-To: <56E08098.5050403@redhat.com> --ce0fudUWvXrDVqPMMQHeFAU6Cppq0Galm Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/03/2016 20:59, Eric Blake wrote: > On 03/09/2016 10:47 AM, Paolo Bonzini wrote: >> > On 09/03/2016 18:28, Daniel P. Berrange wrote: >>> >> From: Paolo Bonzini >> >=20 >> > Reviewing my own patch looks weird. :) >> >=20 >>> >> On Win32 we cannot directly poll on socket handles. Instead we >>> >> create a Win32 event object and associate the socket handle with >>> >> the event. When the event signals readyness we then have to >>> >> use select to determine which events are ready. Creating Win32 >>> >> events is moderately heavyweight, so we don't want todo it >>> >> every time we create a GSource, so this associates a single >>> >> event with a QIOChannel. >>> >> >>> >> Signed-off-by: Daniel P. Berrange >>> >> --- > Especially when it lacks your S-o-b :) I'm innocent! :) https://github.com/bonzini/qemu/commit/win32-qio-watch^ Paolo --ce0fudUWvXrDVqPMMQHeFAU6Cppq0Galm-- --DwrR9vgEb4JMJnifsOLt9cmRapApiEC8D Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJW4JSjAAoJEL/70l94x66D9zAIAJyti1qT9QJSNVCwUBRml2BO RLGJkkI/+y0HFg4CwHPhmepONYQK8NacFRjFVxjiLvBixmrd/KAhL6giuJDFvrTK D1RsNMTmoSwgI6Stqsrkqj27w4E+q4X+yLpL6TjTFBULNgw0YlKR/fpe15uhOiJv +iHSt41X5S01k3K+gttoq6VM8Z8HT/dC48JJ+Q6FoEJxioVkJlH7jqc7nOsO/G+f 6EqKmUbICKUtOzCGlDu31FJFf4IGARMyan5VeiTzELpONOYcZdbDsp0RH0cJwv2U jQ+dovO+7URgkQdmR/9vNohgOURXemMYQTBkGdRXrwET++1Opc2nUV3NfhwLVTY= =jgjn -----END PGP SIGNATURE----- --DwrR9vgEb4JMJnifsOLt9cmRapApiEC8D--