From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59435)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1adxIy-00064F-39
	for qemu-devel@nongnu.org; Thu, 10 Mar 2016 04:54:56 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1adxIu-0006oo-Qx
	for qemu-devel@nongnu.org; Thu, 10 Mar 2016 04:54:52 -0500
Received: from mail-wm0-x244.google.com ([2a00:1450:400c:c09::244]:33273)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1adxIu-0006ok-Ic
	for qemu-devel@nongnu.org; Thu, 10 Mar 2016 04:54:48 -0500
Received: by mail-wm0-x244.google.com with SMTP id n186so2831036wmn.0
	for <qemu-devel@nongnu.org>; Thu, 10 Mar 2016 01:54:48 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
References: <1457544504-8548-1-git-send-email-berrange@redhat.com>
	<1457544504-8548-13-git-send-email-berrange@redhat.com>
	<56E061B1.9040706@redhat.com> <56E08098.5050403@redhat.com>
	<56E094A3.5010103@redhat.com> <20160310094155.GD25607@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <56E14465.8060607@redhat.com>
Date: Thu, 10 Mar 2016 10:54:45 +0100
MIME-Version: 1.0
In-Reply-To: <20160310094155.GD25607@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v1 12/21] io: implement socket watch for
 win32 using WSAEventSelect+select
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: Stefan Weil <sw@weilnetz.de>, qemu-devel@nongnu.org, Andrew Baumann <Andrew.Baumann@microsoft.com>



On 10/03/2016 10:41, Daniel P. Berrange wrote:
>> > 
>> > https://github.com/bonzini/qemu/commit/win32-qio-watch^
> Since I made non-trivial changes to this commit, I thought it was
> corrrect to remove your S-o-b, to avoid claiming that you'd already
> signed off on the changes I made. Was that not the right thing
> todo ?

You should have then also removed the authorship.  I think in this case
leaving the author and the s-o-b was the right thing to do, followed by
removing the authorship and leaving the s-o-b.  Signed-off-by is more of
a legal thing than a "I think that these changes are good for QEMU".

Paolo