From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43277) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adxyq-0001iz-PK for qemu-devel@nongnu.org; Thu, 10 Mar 2016 05:38:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1adxyl-0002v6-Vc for qemu-devel@nongnu.org; Thu, 10 Mar 2016 05:38:08 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40825) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adxyl-0002v2-QG for qemu-devel@nongnu.org; Thu, 10 Mar 2016 05:38:03 -0500 References: <1457544488-5276-1-git-send-email-cornelia.huck@de.ibm.com> <1457544488-5276-5-git-send-email-cornelia.huck@de.ibm.com> <56E09BD2.9070803@redhat.com> <20160310105255.7780b6f1.cornelia.huck@de.ibm.com> From: Thomas Huth Message-ID: <56E14E87.8070105@redhat.com> Date: Thu, 10 Mar 2016 11:37:59 +0100 MIME-Version: 1.0 In-Reply-To: <20160310105255.7780b6f1.cornelia.huck@de.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.6 04/10] s390x/cpu: Tolerate max_cpus List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck Cc: Matthew Rosato , agraf@suse.de, qemu-devel@nongnu.org, Markus Armbruster , borntraeger@de.ibm.com, jfrei@linux.vnet.ibm.com On 10.03.2016 10:52, Cornelia Huck wrote: > On Wed, 9 Mar 2016 22:55:30 +0100 > Thomas Huth wrote: > >> While you're at it, it might be better to use g_new0 here instead >> (see e.g. https://patchwork.ozlabs.org/patch/517377/ for a description >> why this is better). > > Using g_new0 sounds sensible; but rather than respinning again, I'll > just put the following on top: > > From 0a11840959f61861672858ce961fc34b71efa3be Mon Sep 17 00:00:00 2001 > From: Cornelia Huck > Date: Thu, 10 Mar 2016 10:19:46 +0100 > Subject: [PATCH] s390x/cpu: use g_new0 > > Let's use g_new0 to allocate cpu_states. > > Suggested-by: Thomas Huth > Signed-off-by: Cornelia Huck > --- > hw/s390x/s390-virtio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/s390x/s390-virtio.c b/hw/s390x/s390-virtio.c > index 4ea9040..7c6e281 100644 > --- a/hw/s390x/s390-virtio.c > +++ b/hw/s390x/s390-virtio.c > @@ -103,7 +103,7 @@ void s390_init_cpus(MachineState *machine) > machine->cpu_model = "host"; > } > > - cpu_states = g_malloc0(sizeof(S390CPU *) * max_cpus); > + cpu_states = g_new0(S390CPU *, max_cpus); > > for (i = 0; i < max_cpus; i++) { > name = g_strdup_printf("cpu[%i]", i); Reviewed-by: Thomas Huth