From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50114) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ae3Cg-0001r6-JX for qemu-devel@nongnu.org; Thu, 10 Mar 2016 11:12:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ae3CZ-0001d1-HI for qemu-devel@nongnu.org; Thu, 10 Mar 2016 11:12:46 -0500 Received: from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243]:35178) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ae3CZ-0001cm-Am for qemu-devel@nongnu.org; Thu, 10 Mar 2016 11:12:39 -0500 Received: by mail-wm0-x243.google.com with SMTP id n205so4737045wmf.2 for ; Thu, 10 Mar 2016 08:12:38 -0800 (PST) Sender: Paolo Bonzini References: <1457544504-8548-1-git-send-email-berrange@redhat.com> <1457544504-8548-2-git-send-email-berrange@redhat.com> From: Paolo Bonzini Message-ID: <56E19CF4.1090909@redhat.com> Date: Thu, 10 Mar 2016 17:12:36 +0100 MIME-Version: 1.0 In-Reply-To: <1457544504-8548-2-git-send-email-berrange@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v1 01/21] osdep: fix socket_error() to work with Mingw64 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: Stefan Weil , Andrew Baumann On 09/03/2016 18:28, Daniel P. Berrange wrote: > + case WSAEWOULDBLOCK: > + return EWOULDBLOCK; On mingw EAGAIN != EWOULDBLOCK. Can you instead return EAGAIN here, so that we can get rid of the "... || errno == EWOULDBLOCK" everywhere? Paolo