From: Eric Blake <eblake@redhat.com>
To: Jitendra Kolhe <jitendra.kolhe@hpe.com>
Cc: simhan@hpe.com, mohan_parthasarathy@hpe.com,
qemu-devel@nongnu.org, dgilbert@redhat.com
Subject: Re: [Qemu-devel] [PATCH v1] migration: skip sending ram pages released by virtio-balloon driver.
Date: Thu, 10 Mar 2016 10:27:03 -0700 [thread overview]
Message-ID: <56E1AE67.4040708@redhat.com> (raw)
In-Reply-To: <1457600259-2662-1-git-send-email-jitendra.kolhe@hpe.com>
[-- Attachment #1: Type: text/plain, Size: 1316 bytes --]
On 03/10/2016 01:57 AM, Jitendra Kolhe wrote:
>>> +++ b/qapi-schema.json
>>> @@ -544,11 +544,14 @@
>>> # been migrated, pulling the remaining pages along as needed. NOTE: If
>>> # the migration fails during postcopy the VM will fail. (since 2.5)
>>> #
>>> +# @skip-balloon: Skip scaning ram pages released by virtio-balloon driver.
>>
>> s/scaning/scanning/
>>
>>> +# (since 2.5)
>>
>> You've missed 2.5. In fact, this is borderline between new feature and
>> bug fix, so you may have even missed 2.6 since soft freeze has already
>> passed, in which case this should read 2.7.
>
> Thanks for sharing the timeline was not aware of it. I think making changes to
> version 2.7 should be fine. However the version string "(since 2.5)" is
> part of existing code. I have added a new option "skip-balloon" below it.
MigrationCapability is since 1.2, x-postcopy-ram is since 2.5, and your
addition of skip-balloon is since 2.7. In other words, when you
copy-pasted x-postcopy-ram's "(since 2.5)" as your starting point for
writing the docs for your new skip-balloon, you need to update the
version in which your new capability is actually exposed.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-03-10 17:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-10 8:57 [Qemu-devel] [PATCH v1] migration: skip sending ram pages released by virtio-balloon driver Jitendra Kolhe
2016-03-10 17:27 ` Eric Blake [this message]
2016-03-11 2:20 ` Jitendra Kolhe
-- strict thread matches above, loose matches on Subject: below --
2016-03-04 9:02 Jitendra Kolhe
2016-03-07 17:05 ` Eric Blake
2016-03-10 9:49 ` Roman Kagan
2016-03-11 5:59 ` Jitendra Kolhe
2016-03-11 7:25 ` Li, Liang Z
2016-03-11 10:20 ` Jitendra Kolhe
2016-03-11 10:54 ` Li, Liang Z
2016-03-11 14:39 ` Jitendra Kolhe
2016-03-15 13:20 ` Jitendra Kolhe
2016-03-18 11:27 ` Roman Kagan
2016-03-22 5:47 ` Jitendra Kolhe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E1AE67.4040708@redhat.com \
--to=eblake@redhat.com \
--cc=dgilbert@redhat.com \
--cc=jitendra.kolhe@hpe.com \
--cc=mohan_parthasarathy@hpe.com \
--cc=qemu-devel@nongnu.org \
--cc=simhan@hpe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).