From: Eric Blake <eblake@redhat.com>
To: rutu.shah.26@gmail.com, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, kvm@vger.kernel.org, mst@redhat.com,
jasowang@redhat.com, mark.cave-ayland@ilande.co.uk,
agraf@suse.de, kraxel@redhat.com, qemu-block@nongnu.org,
armbru@redhat.com, borntraeger@de.ibm.com,
samuel.thibault@ens-lyon.org, alistair.francis@xilinx.com,
qemu-arm@nongnu.org, stefanha@redhat.com, imammedo@redhat.com,
cornelia.huck@de.ibm.com, lcapitulino@redhat.com,
jsnow@redhat.com, rth@twiddle.net, kwolf@redhat.com,
crosthwaite.peter@gmail.com, blauwirbel@gmail.co,
qemu-ppc@nongnu.org, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH] Replacing (and removing) get_ticks_per_sec() function with NANOSECONDS_PER_SECOND Signed-off-by: Rutuja Shah <rutu.shah.26@gmail.com>
Date: Thu, 10 Mar 2016 14:10:51 -0700 [thread overview]
Message-ID: <56E1E2DB.1020603@redhat.com> (raw)
In-Reply-To: <1457638209-14218-1-git-send-email-rutu.shah.26@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 712 bytes --]
On 03/10/2016 12:30 PM, rutu.shah.26@gmail.com wrote:
> From: Rutuja Shah <rutu.shah.26@gmail.com>
>
Your commit message body was botched, cramming everything into the
subject line. Be sure you have a one-line summary (preferably shorter
than 60 characters), then a blank line, before the rest of your
description and S-o-b. Also, it's good to say "why" in the commit body,
not just "what". Something like:
maint: Drop unused get_ticks_per_sec()
Replace the use of get_ticks_per_sec() with NANOSECONDS_PER_SECOND,
because...
Signed-off-by: Rutuja Shah <rutu.shah.26@gmail.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-03-10 21:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-10 19:30 [Qemu-devel] [PATCH] Replacing (and removing) get_ticks_per_sec() function with NANOSECONDS_PER_SECOND Signed-off-by: Rutuja Shah <rutu.shah.26@gmail.com> rutu.shah.26
2016-03-10 21:10 ` Eric Blake [this message]
2016-03-11 6:57 ` rutuja shah
2016-03-11 11:01 ` Stefan Hajnoczi
2016-03-11 11:44 ` Christian Borntraeger
2016-03-11 12:07 ` Paolo Bonzini
2016-03-11 12:12 ` Christian Borntraeger
2016-03-11 12:26 ` Paolo Bonzini
2016-03-11 13:22 ` Christian Borntraeger
2016-03-12 16:20 ` rutuja shah
2016-03-15 10:08 ` [Qemu-devel] [Qemu-ppc] " Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E1E2DB.1020603@redhat.com \
--to=eblake@redhat.com \
--cc=agraf@suse.de \
--cc=alistair.francis@xilinx.com \
--cc=armbru@redhat.com \
--cc=blauwirbel@gmail.co \
--cc=borntraeger@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=crosthwaite.peter@gmail.com \
--cc=imammedo@redhat.com \
--cc=jasowang@redhat.com \
--cc=jsnow@redhat.com \
--cc=kraxel@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rth@twiddle.net \
--cc=rutu.shah.26@gmail.com \
--cc=samuel.thibault@ens-lyon.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).