From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38063) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aeMHn-00047A-2v for qemu-devel@nongnu.org; Fri, 11 Mar 2016 07:35:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aeMHm-00015g-8t for qemu-devel@nongnu.org; Fri, 11 Mar 2016 07:35:19 -0500 References: <8ad83e37ec80ac89ee7a30426c4b0f2c02e033eb.1457539274.git.berto@igalia.com> <56E0555F.9010704@redhat.com> From: Max Reitz Message-ID: <56E2BB7C.2040600@redhat.com> Date: Fri, 11 Mar 2016 13:35:08 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="KaV8iPTqgJc8V3xJfUHN9ftOl7B6af3kG" Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 1/4] quorum: Fix crash in quorum_aio_cb() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alberto Garcia , qemu-devel@nongnu.org Cc: qemu-block@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --KaV8iPTqgJc8V3xJfUHN9ftOl7B6af3kG Content-Type: multipart/mixed; boundary="0IT7JsuhhSnBFfV67oDBKEHIb2Fd2ejdn" From: Max Reitz To: Alberto Garcia , qemu-devel@nongnu.org Cc: qemu-block@nongnu.org Message-ID: <56E2BB7C.2040600@redhat.com> Subject: Re: [Qemu-block] [PATCH 1/4] quorum: Fix crash in quorum_aio_cb() References: <8ad83e37ec80ac89ee7a30426c4b0f2c02e033eb.1457539274.git.berto@igalia.com> <56E0555F.9010704@redhat.com> In-Reply-To: --0IT7JsuhhSnBFfV67oDBKEHIb2Fd2ejdn Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 10.03.2016 11:10, Alberto Garcia wrote: > On Wed 09 Mar 2016 05:54:55 PM CET, Max Reitz wrote= : >> On 09.03.2016 17:11, Alberto Garcia wrote: >>> quorum_aio_cb() emits the QUORUM_REPORT_BAD event if there's >>> an I/O error in a Quorum child. However sacb->aiocb must be >>> correctly initialized for this to happen. read_quorum_children() and >>> read_fifo_child() are not doing this, which results in a QEMU crash. >>> >>> Signed-off-by: Alberto Garcia >>> --- >>> block/quorum.c | 12 +++++++----- >>> 1 file changed, 7 insertions(+), 5 deletions(-) >> >> Reviewed-by: Max Reitz >> >> Although I'm wondering whether we could have just used acb->common.bs >> instead of sacb->aiocb->bs in quorum_aio_cb(). I guess that >> sacb->aiocb is supposed to be equal to &acb->common. >=20 > acb->common.bs is the Quorum BDS, sacb->aiocb->bs is the child BDS. You're right, thanks for explaining. Max --0IT7JsuhhSnBFfV67oDBKEHIb2Fd2ejdn-- --KaV8iPTqgJc8V3xJfUHN9ftOl7B6af3kG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJW4rt8AAoJEDuxQgLoOKytm9sH/1+OVFt6XJT0UV7QZkVyApCE eAYRVkvs5AVgROACsXNGV8zuL8FaT0wH7pafWXZc7zKSK+cuDLijO1MFvP/Y5SVj SfFGohT+oujmFkicPDC0gjWLI/q8FdhVh/5ymfX4+cHW1vz98WAEMk31v6/9QIj8 bDGUGRYIr4ReN+di7ZEE7+Vs9pTS/wrKO2XfR1PakzNUlL4qV2kJsz+Cvvn2if3n mCUGwrNERcfxO7lUz4qQhGbPFAQgJq8B7rkj+USWQygY3bHqHpP+axdAPbK5PHlP UM0eoC8SEi9a6L7+It6RxkyhQw534i7I7nYERMW6ilTMK6ms4XHH/rL9DWXOnK0= =8BIb -----END PGP SIGNATURE----- --KaV8iPTqgJc8V3xJfUHN9ftOl7B6af3kG--