From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46671) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aeON9-0001B9-1j for qemu-devel@nongnu.org; Fri, 11 Mar 2016 09:49:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aeON8-0002W1-5k for qemu-devel@nongnu.org; Fri, 11 Mar 2016 09:48:58 -0500 References: <1457412306-18940-1-git-send-email-famz@redhat.com> <1457412306-18940-8-git-send-email-famz@redhat.com> From: Max Reitz Message-ID: <56E2DAD1.1010104@redhat.com> Date: Fri, 11 Mar 2016 15:48:49 +0100 MIME-Version: 1.0 In-Reply-To: <1457412306-18940-8-git-send-email-famz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Bmv2B3QgU6gFraTvFHWdrh8rhouLBUii7" Subject: Re: [Qemu-devel] [PATCH v4 07/15] HBitmap: Introduce "meta" bitmap to track bit changes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: kwolf@redhat.com, Vladimir Sementsov-Ogievskiy , jsnow@redhat.com, qemu-block@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Bmv2B3QgU6gFraTvFHWdrh8rhouLBUii7 Content-Type: multipart/mixed; boundary="hS44QnufqeubGqQwkNnMhKakBvdaTj7rB" From: Max Reitz To: Fam Zheng , qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, Vladimir Sementsov-Ogievskiy , jsnow@redhat.com, kwolf@redhat.com Message-ID: <56E2DAD1.1010104@redhat.com> Subject: Re: [PATCH v4 07/15] HBitmap: Introduce "meta" bitmap to track bit changes References: <1457412306-18940-1-git-send-email-famz@redhat.com> <1457412306-18940-8-git-send-email-famz@redhat.com> In-Reply-To: <1457412306-18940-8-git-send-email-famz@redhat.com> --hS44QnufqeubGqQwkNnMhKakBvdaTj7rB Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 08.03.2016 05:44, Fam Zheng wrote: > Upon each bit toggle, the corresponding bit in the meta bitmap will be > set. >=20 > Signed-off-by: Fam Zheng > Reviewed-by: John Snow > --- > block/dirty-bitmap.c | 2 +- > include/qemu/hbitmap.h | 17 +++++++++++++ > util/hbitmap.c | 66 ++++++++++++++++++++++++++++++++++++++----= -------- > 3 files changed, 69 insertions(+), 16 deletions(-) >=20 > diff --git a/block/dirty-bitmap.c b/block/dirty-bitmap.c > index 16f73b2..0a188f2 100644 > --- a/block/dirty-bitmap.c > +++ b/block/dirty-bitmap.c > @@ -231,7 +231,7 @@ static void bdrv_do_release_matching_dirty_bitmap(B= lockDriverState *bs, > BdrvDirtyBitmap *bm, *next; > QLIST_FOREACH_SAFE(bm, &bs->dirty_bitmaps, list, next) { > if ((!bitmap || bm =3D=3D bitmap) && (!only_named || bm->name)= ) { > - assert(!bitmap->active_iterators); > + assert(!bm->active_iterators); I guess this should be squashed into patch 6. Good point, by the way, yes, using bitmap is wrong here. :-) Max --hS44QnufqeubGqQwkNnMhKakBvdaTj7rB-- --Bmv2B3QgU6gFraTvFHWdrh8rhouLBUii7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJW4trRAAoJEDuxQgLoOKytvzgH/jub/UGHJ4mmvIor9JL9cKF2 Y5zLsnK7alHv9MAL5KZ8e2AZLiEirv8rPHUECvDelXMYJ+7QHqQN/QnV/3sVzrn0 3Fh5ed7LUrO5/df7+3RnktemVJftiFvn0CU1RDnw00Bz7XZTL1DkLuGYAfXbWqKt ZH8yjpqLPo0WNavIvMaeo4w/ohA8GAO+kqBxH+I8Tn2go+cZkRN1O2+ObEdm3LNV 0zl9hBlT91THIrNrDSHwJdSSL/udW4dNQtGMZ0+W6wAH/qNbe+ZwcLNJmbO2yiMb r6TXsXe3mFzrV9cD5/ECjqjp1VbV/c6s1cMihX4BmjPN/eD1Jo/p9qBEsQPeOGU= =qOme -----END PGP SIGNATURE----- --Bmv2B3QgU6gFraTvFHWdrh8rhouLBUii7--