From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58014) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aeOwU-00050m-Gr for qemu-devel@nongnu.org; Fri, 11 Mar 2016 10:25:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aeOwH-0005lV-0D for qemu-devel@nongnu.org; Fri, 11 Mar 2016 10:25:30 -0500 References: <1457412306-18940-1-git-send-email-famz@redhat.com> <1457412306-18940-12-git-send-email-famz@redhat.com> From: Max Reitz Message-ID: <56E2E34F.4080602@redhat.com> Date: Fri, 11 Mar 2016 16:25:03 +0100 MIME-Version: 1.0 In-Reply-To: <1457412306-18940-12-git-send-email-famz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="gAhNXgJ2DWtpPsj013NN3Gd2iQ9sQRuVT" Subject: Re: [Qemu-devel] [PATCH v4 11/15] block: Assert that bdrv_release_dirty_bitmap succeeded List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: kwolf@redhat.com, Vladimir Sementsov-Ogievskiy , jsnow@redhat.com, qemu-block@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --gAhNXgJ2DWtpPsj013NN3Gd2iQ9sQRuVT Content-Type: multipart/mixed; boundary="BNgMtDVumgwKnNln4MMSF7tdlRj5hrPV8" From: Max Reitz To: Fam Zheng , qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, Vladimir Sementsov-Ogievskiy , jsnow@redhat.com, kwolf@redhat.com Message-ID: <56E2E34F.4080602@redhat.com> Subject: Re: [PATCH v4 11/15] block: Assert that bdrv_release_dirty_bitmap succeeded References: <1457412306-18940-1-git-send-email-famz@redhat.com> <1457412306-18940-12-git-send-email-famz@redhat.com> In-Reply-To: <1457412306-18940-12-git-send-email-famz@redhat.com> --BNgMtDVumgwKnNln4MMSF7tdlRj5hrPV8 Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 08.03.2016 05:45, Fam Zheng wrote: > We use a loop over bs->dirty_bitmaps to make sure the caller is > only releasing a bitmap owned by bs. Let's also assert that in this cas= e > the caller is releasing a bitmap that does exist. >=20 > Signed-off-by: Fam Zheng > --- > block/dirty-bitmap.c | 3 +++ > 1 file changed, 3 insertions(+) Reviewed-by: Max Reitz --BNgMtDVumgwKnNln4MMSF7tdlRj5hrPV8-- --gAhNXgJ2DWtpPsj013NN3Gd2iQ9sQRuVT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJW4uNPAAoJEDuxQgLoOKytlgAIAJJQ7GgTBQdiUSX2Xv+xoH6c O5cgdgQnbPKJp5nwUXq7jr+omqOAMzu3uTix8+KBP5yFxHjdmwsSne4a7IuH92ky tK4MAHa1FMZ1dUmTliZoPFNvcC/N1OFb7GAfJ2fYh+44rVFIlliygr72ZtLIGEL+ uN/NGpNXenqA1JUMh5h8hM2IZfFfy1xs2rOCTJTzmTyPTX7cq29kDv2zcB1vycTP ObcPm/ZJIU0Pw/OrqKR1e54ISjHvKF+DiDZJijp4+7lHMT6i18WXKMip6t56UhKz tYzsFyczE3SmKCxYTRXoRBPUhxaUvlMdfTGm2EnZbGY+q8zBtLKwZtWaEUf47DI= =Yjs/ -----END PGP SIGNATURE----- --gAhNXgJ2DWtpPsj013NN3Gd2iQ9sQRuVT--