From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40492) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aeQsU-00061T-LQ for qemu-devel@nongnu.org; Fri, 11 Mar 2016 12:29:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aeQsR-0005Du-Fq for qemu-devel@nongnu.org; Fri, 11 Mar 2016 12:29:30 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36729) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aeQsR-0005Dj-AH for qemu-devel@nongnu.org; Fri, 11 Mar 2016 12:29:27 -0500 References: <1457571335-10938-1-git-send-email-eblake@redhat.com> <1457571335-10938-5-git-send-email-eblake@redhat.com> <8737rytptn.fsf@blackfin.pond.sub.org> <56E19CBC.90605@redhat.com> <87r3fhlakj.fsf@blackfin.pond.sub.org> From: Eric Blake Message-ID: <56E30076.4080404@redhat.com> Date: Fri, 11 Mar 2016 10:29:26 -0700 MIME-Version: 1.0 In-Reply-To: <87r3fhlakj.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="o9I35iHWpBCtbtOIgm2m16whgBrNo4hrK" Subject: Re: [Qemu-devel] [PATCH v5 04/14] qapi: Adjust names of implicit types List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, Michael Roth This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --o9I35iHWpBCtbtOIgm2m16whgBrNo4hrK Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/11/2016 12:48 AM, Markus Armbruster wrote: >>>> time to change our naming convention; we can instead use the 'q_' >>>> prefix that we reserved for ourselves back in commit 9fb081e0. As >>>> long as we don't declare 'empty' or 'obj' ticklish, it shouldn't >>>> clash with c_name() prepending 'q_' to the user's ticklish names. >>> >>> Do we really want to rename :empty? We're not going to generate C fo= r >>> it, are we? >> >> No, but it was easier to implement .is_implicit() as >> "name.startswith('q_')" than as "name =3D=3D ':empty' or >> name.startswith('q_obj')". I can stick with :empty if you want a >> respin, though. >=20 > You avoid complicating .is_implicit() slightly, and you pay for that > with a bit of patch churn elsewhere. Sounds justified. >=20 > Is ':empty' the last use of the ':' prefix? Yes. And renaming it to 'q_empty' meant I didn't have to add ':' to the set of characters to be transliterated in c_name(). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --o9I35iHWpBCtbtOIgm2m16whgBrNo4hrK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJW4wB2AAoJEKeha0olJ0NqlMAIAIgSy5huvDbkN4xaDnX3/PAn DUIme+yZJEIE4KvVxMvOBMlpHXe6aTVlCAqAbG0tiTloGoaDLNYQ+zRz2aOlyBAy NeEiQWa7x7bCJErivrjwEda1BG/tWYTpRsyVCTB9GV+HQwxo2GGCyz8dr5rLMiJx QptUwq6+UdPd8gzTZMZ7W8n7uuY3CJt9hBmFTT8194wFCv421xTVUcJ4AlWCcdZ6 0NzCn4K/xrYBUuv2dmCvthOn+WvQNlDq/R0nY32fhCx+NrPv1U18083xpsmo4B/O fd+xUO8Qx1IJ/ECdiRB4pdOw+k1wEXBes0z3lY9tFFdy2jVCfJZ4jI87lHcHmdc= =a2Ha -----END PGP SIGNATURE----- --o9I35iHWpBCtbtOIgm2m16whgBrNo4hrK--