From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35337) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aenal-0000VY-TC for qemu-devel@nongnu.org; Sat, 12 Mar 2016 12:44:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aenai-0007g6-NX for qemu-devel@nongnu.org; Sat, 12 Mar 2016 12:44:43 -0500 References: <1457789937-30923-1-git-send-email-hpoussin@reactos.org> <56E434A7.604@ilande.co.uk> From: =?UTF-8?Q?Herv=c3=a9_Poussineau?= Message-ID: <56E45581.3000109@reactos.org> Date: Sat, 12 Mar 2016 18:44:33 +0100 MIME-Version: 1.0 In-Reply-To: <56E434A7.604@ilande.co.uk> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] adb: change handler only when recognized List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark Cave-Ayland , qemu-devel@nongnu.org Cc: Peter Maydell , qemu-ppc@nongnu.org, programmingkidx@gmail.com Le 12/03/2016 16:24, Mark Cave-Ayland a =C3=A9crit : > On 12/03/16 13:38, Herv=C3=A9 Poussineau wrote: > >> ADB devices must take new handler into account only when they recogniz= e it. >> This lets operating systems probe for valid/invalid handles, to know d= evice capabilities. >> >> Add a FIXME in keyboard handler, which should use a different translat= ion >> table depending of the selected handler. >> >> Signed-off-by: Herv=C3=A9 Poussineau > > Interesting. Can you explain a bit more about which OSs this patch > affects and the symptoms it alleviates? Here is a small list of handlers requested by some operating systems with= out the patch HelenOS kbd=3D1 mouse=3D2 MacOS 9 kbd=3D1 mouse=3D0xc (what is 0xc?) Linux kbd=3D3 mouse=3D4 Here is a small list of handlers requested by some operating systems with= the patch HelenOS kbd=3D1 mouse=3D2 MacOS 9 kbd=3D1 mouse=3D2 Linux kbd=3D3 mouse=3D2 I have no example of current problem with the keyboard part. However, I s= uspect it may be related some problems John is seeing on some operating systems, as handler 1 and 2/3 m= ust not use the same translation table. Note that MacOS 9 uses handler 1 (Apple Standard Keyboard), while Linux u= ses handler 3 (Apple Extended Keyboard LShift !=3D RShift). On mouse part, operating systems (like MacOS or Linux) try to probe the m= ouse model by testing different handlers, and see which ones are accepted. On Linux, the handler 1 and 2 have a 3 bytes protocol, while the handler = 4 has a 4 bytes protocol. Correctly supporting protocol 4 will be required to handle 3-button mice. Herv=C3=A9