From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47899) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afHjK-0004Cq-Fo for qemu-devel@nongnu.org; Sun, 13 Mar 2016 21:55:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1afHjJ-0003fX-Aj for qemu-devel@nongnu.org; Sun, 13 Mar 2016 21:55:34 -0400 Message-ID: <56E61A8B.2000405@cn.fujitsu.com> Date: Mon, 14 Mar 2016 09:57:31 +0800 From: Changlong Xie MIME-Version: 1.0 References: <1457612036-8953-1-git-send-email-berto@igalia.com> <56E21FF3.9000603@cn.fujitsu.com> In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] quorum: Fix crash in quorum_aio_cb() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alberto Garcia , Wen Congyang , qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org, qemu-block@nongnu.org, Max Reitz On 03/11/2016 04:25 PM, Alberto Garcia wrote: > On Fri 11 Mar 2016 02:31:31 AM CET, Wen Congyang wrote: >> On 03/10/2016 08:13 PM, Alberto Garcia wrote: >>> quorum_aio_cb() emits the QUORUM_REPORT_BAD event if there's >>> an I/O error in a Quorum child. However sacb->aiocb must be >>> correctly initialized for this to happen. read_quorum_children() and >>> read_fifo_child() are not doing this, which results in a QEMU crash. >> >> If we use FIFO mode, we don't call quorum_report_bad() in >> quorum_aio_cb(). But it is OK to iniialize sacb->aiocb for it. > Hi betro > You're right. I still think it's a good idea to leave it initialized in > case we change that in the future. Yes. > > And now that we're at it, shouldn't we call quorum_report_bad() in FIFO > mode as well? Or is there any reason not to do it? IMO, no reason not to do it. Thanks -Xie > > Berto > > > >