Re: [Qemu-devel] [PATCH 1/5] address_space: replaced function calls

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1319 bytes --]

On 03/13/2016 01:10 PM, Peter Maydell wrote:
> On 13 March 2016 at 18:56, Mriyam Tamuli <mbtamuli@gmail.com> wrote:
>> replaced calls named cpu_physical_memory_* with address_space_*
>>
>> cpus.c
>> cputlb.c
>> disas.c
>> exec.c
>> ---
>>  cpus.c   |  2 +-
>>  cputlb.c |  8 ++++----
>>  disas.c  |  2 +-
>>  exec.c   | 60 ++++++++++++++++++++++++++++++------------------------------
>>  4 files changed, 36 insertions(+), 36 deletions(-)
>>
>> diff --git a/cpus.c b/cpus.c
>> index bc774e2..d73cd7b 100644
>> --- a/cpus.c
>> +++ b/cpus.c
>> @@ -1662,7 +1662,7 @@ void qmp_pmemsave(int64_t addr, int64_t size, const char *filename,
>>          l = sizeof(buf);
>>          if (l > size)
>>              l = size;
>> -        cpu_physical_memory_read(addr, buf, l);
>> +        address_space_read(addr, buf, l);
> 
> address_space_read() takes five arguments, not three -- surely
> this change won't compile?

Also, sending 5 identically-titled patches is poor form; it makes life
harder for backporting.  Please make sure all 5 patches have different
subject lines, with proper threading (each message in-reply-to the 0/5
cover letter, rather than its own top-level thread).

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]