From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52308) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afTGY-00053T-Hb for qemu-devel@nongnu.org; Mon, 14 Mar 2016 10:14:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1afTGS-0004H4-U4 for qemu-devel@nongnu.org; Mon, 14 Mar 2016 10:14:38 -0400 References: <1457895376-22138-1-git-send-email-mbtamuli@gmail.com> From: Eric Blake Message-ID: <56E6C747.10307@redhat.com> Date: Mon, 14 Mar 2016 08:14:31 -0600 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="V7tJ6f8WgwRDq8KrafOVsDFPr1X7c21gW" Subject: Re: [Qemu-devel] [PATCH 1/5] address_space: replaced function calls List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , Mriyam Tamuli Cc: QEMU Trivial , Paolo Bonzini , Richard Henderson , QEMU Developers , Peter Crosthwaite This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --V7tJ6f8WgwRDq8KrafOVsDFPr1X7c21gW Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/13/2016 01:10 PM, Peter Maydell wrote: > On 13 March 2016 at 18:56, Mriyam Tamuli wrote: >> replaced calls named cpu_physical_memory_* with address_space_* >> >> cpus.c >> cputlb.c >> disas.c >> exec.c >> --- >> cpus.c | 2 +- >> cputlb.c | 8 ++++---- >> disas.c | 2 +- >> exec.c | 60 ++++++++++++++++++++++++++++++-------------------------= ----- >> 4 files changed, 36 insertions(+), 36 deletions(-) >> >> diff --git a/cpus.c b/cpus.c >> index bc774e2..d73cd7b 100644 >> --- a/cpus.c >> +++ b/cpus.c >> @@ -1662,7 +1662,7 @@ void qmp_pmemsave(int64_t addr, int64_t size, co= nst char *filename, >> l =3D sizeof(buf); >> if (l > size) >> l =3D size; >> - cpu_physical_memory_read(addr, buf, l); >> + address_space_read(addr, buf, l); >=20 > address_space_read() takes five arguments, not three -- surely > this change won't compile? Also, sending 5 identically-titled patches is poor form; it makes life harder for backporting. Please make sure all 5 patches have different subject lines, with proper threading (each message in-reply-to the 0/5 cover letter, rather than its own top-level thread). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --V7tJ6f8WgwRDq8KrafOVsDFPr1X7c21gW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJW5sdHAAoJEKeha0olJ0NqPCYIAJsD36XdgeG3HF5rMW3BWfQz Huewumf/82p4Y6BCahxgyPJzBdVeKA0oT0jwxrTwxRKL0wCLa97areZdMeCTFQEK gplB/HjMds3LULhZSTqCH9aOegKTzOOOHa30Y9E9i0bjoIysmzcGNMskc5nOJ4Si xxNw9YxwOLu3M5FdWRb2T+6DOPKebVc56CsDMjdu1DxozFf9oU/MViILAd1Py6dw Un1w8lj4vf8c02UWe3Whb8kFyweZga58sqJE6hyctlMnjDXsGdztMYvlmb5DAWH0 uKoeg3ozK3SMmcERttD3lSdNLJO3wQdk9IaJoOuKAmOrEzXsetdKlha8thsyQkI= =nPXJ -----END PGP SIGNATURE----- --V7tJ6f8WgwRDq8KrafOVsDFPr1X7c21gW--