From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55626) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afTQY-0004vr-2j for qemu-devel@nongnu.org; Mon, 14 Mar 2016 10:25:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1afTQU-0007D1-2H for qemu-devel@nongnu.org; Mon, 14 Mar 2016 10:24:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53100) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afTQT-0007Cw-TR for qemu-devel@nongnu.org; Mon, 14 Mar 2016 10:24:54 -0400 References: <1457954501-26528-1-git-send-email-den@openvz.org> <1457954501-26528-3-git-send-email-den@openvz.org> From: Paolo Bonzini Message-ID: <56E6C9B1.7000208@redhat.com> Date: Mon, 14 Mar 2016 15:24:49 +0100 MIME-Version: 1.0 In-Reply-To: <1457954501-26528-3-git-send-email-den@openvz.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 2/9] qemu-log: fix cpu_reset log target List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" Cc: Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org, Stefan Hajnoczi , =?UTF-8?Q?Andreas_F=c3=a4rber?= On 14/03/2016 12:21, Denis V. Lunev wrote: > From: Vladimir Sementsov-Ogievskiy >=20 > Do not print superfluous zero cpu state on vm start with -d cpu_reset It's really just the very first reset that is all zeroes. If you use "-S", you can be in prelaunch state and have a meaningful state. Overall I'm not sure that this patch provides a big benefit, but I'll defer to Andreas and others that may want to chime in. Paolo > Signed-off-by: Vladimir Sementsov-Ogievskiy > Signed-off-by: Denis V. Lunev > CC: Stefan Hajnoczi > CC: Paolo Bonzini > CC: Andreas F=C3=A4rber > --- > qom/cpu.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/qom/cpu.c b/qom/cpu.c > index c45d0bb..69e3b87 100644 > --- a/qom/cpu.c > +++ b/qom/cpu.c > @@ -247,7 +247,8 @@ static void cpu_common_reset(CPUState *cpu) > { > CPUClass *cc =3D CPU_GET_CLASS(cpu); > =20 > - if (qemu_loglevel_mask(CPU_LOG_RESET)) { > + if (qemu_loglevel_mask(CPU_LOG_RESET) && > + !runstate_check(RUN_STATE_PRELAUNCH)) { > qemu_log("CPU Reset (CPU %d)\n", cpu->cpu_index); > log_cpu_state(cpu, cc->reset_dump_flags); > } >=20