From: Eric Blake <eblake@redhat.com>
To: rutu.shah.26@gmail.com, qemu-devel@nongnu.org
Cc: mark.cave-ayland@ilande.co.uk, agraf@suse.de,
chouteau@adacore.com, blauwirbel@gmail.com, qemu-ppc@nongnu.org,
stefanha@redhat.com, scottwood@freescale.com
Subject: Re: [Qemu-devel] [PATCH] Added NULL check for qemu_find_file()
Date: Mon, 14 Mar 2016 09:34:39 -0600 [thread overview]
Message-ID: <56E6DA0F.4040609@redhat.com> (raw)
In-Reply-To: <1457814994-10698-1-git-send-email-rutu.shah.26@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1045 bytes --]
On 03/12/2016 01:36 PM, rutu.shah.26@gmail.com wrote:
> From: Rutuja Shah <rutu.shah.26@gmail.com>
>
> This patch adds NULL check for return value from qemu_find_file(), where it is missing. It avoids unnecessary function calls with NULL parameter which in turn return -1. Especially, incase of load_uimage(), two functions are called which return -1 on passing NULL
Please wrap your commit messages at 70 or so columns (since 'git log'
will display your text with indentation, and many people still prefer
80-column terminal windows).
s/incase/in case/
> ---
> hw/ppc/e500.c | 17 +++++++++++++----
> hw/sparc/leon3.c | 6 +++++-
> 2 files changed, 18 insertions(+), 5 deletions(-)
>
>
> Signed-off-by: Rutuja Shah <rutu.shah.26@gmail.com>
This S-o-b is in the wrong place; it needs to appear before the ---
separator to be included in the git log after a maintainer does 'git am'
on your patch.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
prev parent reply other threads:[~2016-03-14 15:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-12 20:36 [Qemu-devel] [PATCH] Added NULL check for qemu_find_file() rutu.shah.26
2016-03-14 11:44 ` Stefan Hajnoczi
2016-03-14 12:59 ` rutuja shah
2016-03-15 12:31 ` Stefan Hajnoczi
2016-03-15 12:56 ` rutuja shah
2016-03-16 11:35 ` Stefan Hajnoczi
2016-03-14 15:34 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E6DA0F.4040609@redhat.com \
--to=eblake@redhat.com \
--cc=agraf@suse.de \
--cc=blauwirbel@gmail.com \
--cc=chouteau@adacore.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rutu.shah.26@gmail.com \
--cc=scottwood@freescale.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).