From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45191) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afUW5-0005aB-Nq for qemu-devel@nongnu.org; Mon, 14 Mar 2016 11:34:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1afUW1-0008Mr-P3 for qemu-devel@nongnu.org; Mon, 14 Mar 2016 11:34:45 -0400 References: <1457814994-10698-1-git-send-email-rutu.shah.26@gmail.com> From: Eric Blake Message-ID: <56E6DA0F.4040609@redhat.com> Date: Mon, 14 Mar 2016 09:34:39 -0600 MIME-Version: 1.0 In-Reply-To: <1457814994-10698-1-git-send-email-rutu.shah.26@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="bSLwePaq8fmAtDv86PHNLtUMnoUpr76wa" Subject: Re: [Qemu-devel] [PATCH] Added NULL check for qemu_find_file() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: rutu.shah.26@gmail.com, qemu-devel@nongnu.org Cc: mark.cave-ayland@ilande.co.uk, agraf@suse.de, chouteau@adacore.com, blauwirbel@gmail.com, qemu-ppc@nongnu.org, stefanha@redhat.com, scottwood@freescale.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --bSLwePaq8fmAtDv86PHNLtUMnoUpr76wa Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/12/2016 01:36 PM, rutu.shah.26@gmail.com wrote: > From: Rutuja Shah >=20 > This patch adds NULL check for return value from qemu_find_file(), wher= e it is missing. It avoids unnecessary function calls with NULL parameter= which in turn return -1. Especially, incase of load_uimage(), two functi= ons are called which return -1 on passing NULL=20 Please wrap your commit messages at 70 or so columns (since 'git log' will display your text with indentation, and many people still prefer 80-column terminal windows). s/incase/in case/ > --- > hw/ppc/e500.c | 17 +++++++++++++---- > hw/sparc/leon3.c | 6 +++++- > 2 files changed, 18 insertions(+), 5 deletions(-) >=20 >=20 > Signed-off-by: Rutuja Shah This S-o-b is in the wrong place; it needs to appear before the --- separator to be included in the git log after a maintainer does 'git am' on your patch. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --bSLwePaq8fmAtDv86PHNLtUMnoUpr76wa Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJW5toPAAoJEKeha0olJ0NqUu0H/jxOrP8COtj2w/lBa/NXXdx6 7X+oaQDxOIIfVwNeQQOWSDjjSxqJ31iTXNQZXAnnRWgK04JSOBt3TUlsWttSgG2I 2LaLaAnybKXaPRbEoHdNW35jhPoxRLA8IXel6dM8y4ZPWBS0b0yv61O9faP+zWeh 7syqSNZYyCDrfoVhBWmjHqnZb6y9ElRKi5dRe9tEuGzwr5zZd3QKBPpSpsy/OwBz V76sRbslkYbcJEA3fiwHklhmnByoZ7v3uJIF/xBJj5foxWygEPYnUKo6dECqqf1x GIxCP00MiBO4tPZolMRZQDAY/wbriESsxiY/qoqANjbwWC2Pb6uniWd0Asn84fY= =hE6u -----END PGP SIGNATURE----- --bSLwePaq8fmAtDv86PHNLtUMnoUpr76wa--