From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50009) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afUpo-0004Ud-GJ for qemu-devel@nongnu.org; Mon, 14 Mar 2016 11:55:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1afUpn-0005A9-7v for qemu-devel@nongnu.org; Mon, 14 Mar 2016 11:55:08 -0400 References: <1457970292-12291-1-git-send-email-kwolf@redhat.com> <1457970292-12291-3-git-send-email-kwolf@redhat.com> From: Eric Blake Message-ID: <56E6DED4.7020800@redhat.com> Date: Mon, 14 Mar 2016 09:55:00 -0600 MIME-Version: 1.0 In-Reply-To: <1457970292-12291-3-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="GrsL2dg8qWXp3a8WXKJW6vNNEjof4DtKS" Subject: Re: [Qemu-devel] [PATCH 2/5] block: Remove dirty bitmaps from bdrv_move_feature_fields() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, jsnow@redhat.com, armbru@redhat.com, mreitz@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --GrsL2dg8qWXp3a8WXKJW6vNNEjof4DtKS Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/14/2016 09:44 AM, Kevin Wolf wrote: > This patch changes dirty bitmaps from following a BlockBackend in graph= > changes to sticking with the node they were created at. For the full > discussion, read the following mailing list thread: >=20 > [Qemu-block] block: Dirty bitmaps and COR in bdrv_move_feature_fields= () > https://lists.nongnu.org/archive/html/qemu-block/2016-02/msg00745.htm= l >=20 > In summary, the justification for this change is: [snip nice list] >=20 > At the end of the day it seems to be very clear that it was a mistake t= o > include dirty bitmaps in bdrv_move_feature_fields(). The functionality > of moving bitmaps and/or attaching them to a BlockBackend instead will > probably be needed, but it should be done with a new explicit QMP > command or option. >=20 > Signed-off-by: Kevin Wolf > --- > block.c | 3 --- > 1 file changed, 3 deletions(-) Reviewed-by: Eric Blake [Always interesting when a patch is way shorter than the justification for why we need the patch] >=20 > diff --git a/block.c b/block.c > index a75c4b3..698e2c7 100644 > --- a/block.c > +++ b/block.c > @@ -2284,9 +2284,6 @@ static void bdrv_move_feature_fields(BlockDriverS= tate *bs_dest, > =20 > /* dev info */ > bs_dest->enable_write_cache =3D bs_src->enable_write_cache; > - > - /* dirty bitmap */ > - bs_dest->dirty_bitmaps =3D bs_src->dirty_bitmaps; > } > =20 > static void change_parent_backing_link(BlockDriverState *from, >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --GrsL2dg8qWXp3a8WXKJW6vNNEjof4DtKS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJW5t7UAAoJEKeha0olJ0NqXFgH/R+qPq65dHTCNJopoyuWbzBw w7ZuHf5ROaOEK1JyDFOknyDzm3YwyDakQiDjITxQPnSszsD53LWP+MxIeuMGoCrP dCqxFSQmBJvRSY8q2FlNdj74S3DrZ3/3ur2RbIR9cVbYF13iyDdorWBQBXHMPSmm TWtvtSdi5wSU5lBL9QBChRZtvqIp+lAwuJ1FkAH2YqnFYVYBQZkxrJgo6BSSVpKD IucG0jv4PSNn9UT3YWtkbF4+UYQ8pCsdQBuIK8yYk4csY5mIpz5QAIpPTL4ieumh CV0G/tkGdWlFhUdBy6W49gDjPHx6zIjv5sib/KF6BcsCA8YZQAaIymLidHNqnTY= =yK5Z -----END PGP SIGNATURE----- --GrsL2dg8qWXp3a8WXKJW6vNNEjof4DtKS--