From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54767) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afV4x-0007rg-CJ for qemu-devel@nongnu.org; Mon, 14 Mar 2016 12:10:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1afV4q-0001Cj-SS for qemu-devel@nongnu.org; Mon, 14 Mar 2016 12:10:47 -0400 References: <1457970292-12291-1-git-send-email-kwolf@redhat.com> <1457970292-12291-4-git-send-email-kwolf@redhat.com> From: Eric Blake Message-ID: <56E6E27A.3080308@redhat.com> Date: Mon, 14 Mar 2016 10:10:34 -0600 MIME-Version: 1.0 In-Reply-To: <1457970292-12291-4-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="e3Ib26BLGeV0kuNTenl7uBvpUon8SCOvp" Subject: Re: [Qemu-devel] [PATCH 3/5] block: Remove cache.writeback from blockdev-add List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, jsnow@redhat.com, armbru@redhat.com, mreitz@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --e3Ib26BLGeV0kuNTenl7uBvpUon8SCOvp Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/14/2016 09:44 AM, Kevin Wolf wrote: > The WCE bit is a frontend property and should not be part of the backen= d > configuration. This is especially important because the same BDS can be= > used by different users with different WCE requirements. >=20 > Signed-off-by: Kevin Wolf > --- > qapi/block-core.json | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) >=20 > diff --git a/qapi/block-core.json b/qapi/block-core.json > index 9bf1b22..e3617e2 100644 > --- a/qapi/block-core.json > +++ b/qapi/block-core.json > @@ -1614,7 +1614,6 @@ > # > # Includes cache-related options for block devices > # > -# @writeback: #optional enables writeback mode for any caches (defau= lt: true) > # @direct: #optional enables use of O_DIRECT (bypass the host pag= e cache; > # default: false) > # @no-flush: #optional ignore any flush requests for the device (de= fault: > @@ -1623,8 +1622,7 @@ > # Since: 1.7 > ## > { 'struct': 'BlockdevCacheOptions', > - 'data': { '*writeback': 'bool', > - '*direct': 'bool', > + 'data': { '*direct': 'bool', > '*no-flush': 'bool' } } Observable through introspection. Not quite backwards-compatible, but at least clients can learn about it, and arguably clients shouldn't have been using it. I can accept it as a bug fix, even though it does risk breaking old clients that were trying to use it. If it helps, libvirt does not seem to have been using it. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --e3Ib26BLGeV0kuNTenl7uBvpUon8SCOvp Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJW5uJ6AAoJEKeha0olJ0NqDtYIAIpxFVnWFb8X9p+7lejfLCpR UsGz0bql6hbIz0i1YhJznY4IUtT9Irz4lPgVrT/HGKPk9Nfvc2OsYnt2pKIc2fcM TwNCv5qQR4n8abZSVdu5CJ71TEY2sPP1yl9AEmbPZIRUv/SxrOaAN5HOiytVVXSJ djSh/6R7rzhHG/yIaz5AH6aSPIFZmT2N9pL74l8f+DcwZgdgptj/kGN5W78xBPMn Tfuiw4ymzeBHQTPNI5vpkHd2teN4U6RZnRP0Mhuf9oxOZhsR1eTdazNthOGgy3jo LSu3Rh8VzqI86lzfGIdzSN/ctlo1e3qA0nsElYIs5S0pBgNKUN3JcoLKlrlN+RM= =4SU3 -----END PGP SIGNATURE----- --e3Ib26BLGeV0kuNTenl7uBvpUon8SCOvp--