From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57975) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afVGN-0007lk-E9 for qemu-devel@nongnu.org; Mon, 14 Mar 2016 12:22:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1afVGM-0004X9-BN for qemu-devel@nongnu.org; Mon, 14 Mar 2016 12:22:35 -0400 References: From: Max Reitz Message-ID: <56E6E542.6080808@redhat.com> Date: Mon, 14 Mar 2016 17:22:26 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Ug1PnspJTmFjg6tm1pS0xKCHfvdD1TCG0" Subject: Re: [Qemu-devel] [PATCH v2 0/4] Separate QUORUM_REPORT_BAD events according to their node name List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alberto Garcia , qemu-devel@nongnu.org Cc: Changlong Xie , qemu-block@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Ug1PnspJTmFjg6tm1pS0xKCHfvdD1TCG0 Content-Type: multipart/mixed; boundary="4KA0RC393FrPkLNiITGaDWev4XaAshWA8" From: Max Reitz To: Alberto Garcia , qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, Eric Blake , Changlong Xie Message-ID: <56E6E542.6080808@redhat.com> Subject: Re: [PATCH v2 0/4] Separate QUORUM_REPORT_BAD events according to their node name References: In-Reply-To: --4KA0RC393FrPkLNiITGaDWev4XaAshWA8 Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 10.03.2016 12:55, Alberto Garcia wrote: > QUORUM_REPORT_BAD events are limited to a maximum rate of 1 per > second. While this is not a problem in itself, this means that an > error in one a Quorum child will mask errors in the other children if > they happen within the same 1 second interval. >=20 > This series fixes that problem by separating these events in different > queues if they come from different nodes. Once we add the 'type' field > to QUORUM_REPORT_BAD we will also be able to classify them according > to the type if we want. >=20 > In addition to the above, this series also fixes a crash that happens > if there's an I/O error in one of the children. This is serious enough > so I'll send the patch to fix this crash to qemu-stable as well. >=20 > Regards, >=20 > Berto >=20 > v2: > - Patch 3: Rename clock_type to event_clock_type [Max] >=20 > v1: https://lists.gnu.org/archive/html/qemu-devel/2016-03/msg02161.html= > - Original version >=20 > Alberto Garcia (4): > quorum: Fix crash in quorum_aio_cb() > monitor: Separate QUORUM_REPORT_BAD events according to the node name= > monitor: Use QEMU_CLOCK_VIRTUAL for the event queue in qtest mode > iotests: Add test for QMP event rates >=20 > block/quorum.c | 12 +++-- > monitor.c | 22 ++++++-- > tests/qemu-iotests/146 | 129 +++++++++++++++++++++++++++++++++++++= ++++++++ > tests/qemu-iotests/146.out | 5 ++ > tests/qemu-iotests/group | 1 + > 5 files changed, 161 insertions(+), 8 deletions(-) > create mode 100644 tests/qemu-iotests/146 > create mode 100644 tests/qemu-iotests/146.out Thanks, applied to my block tree (with the test renamed to 148): https://github.com/XanClic/qemu/commits/block Max --4KA0RC393FrPkLNiITGaDWev4XaAshWA8-- --Ug1PnspJTmFjg6tm1pS0xKCHfvdD1TCG0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJW5uVCAAoJEDuxQgLoOKytFaQH/0qmpVtlWXUke/b/9GBrZnyS UXRfmH0d0egAmuLUaqBaO1f0SUAPzrzEUQ7uIgcB/hlEf/wU8z0iTSUGn4RksCwq HykdfuHAQqoCNCHAX3pthmx7y27d7tVlyXJPBLa8stI96AeuyupeHBdnBqQeae9o PTud7kQGKwyL3o5yWurYws9jcYvmp7ZRiFjMvZsD57j/KRoVviP5v3/7ttARcWjS 8ZpWJR6uQshwooUEKKcD8O4UhGt6S2AaWPUhBo6f9yVyzMJL9VWWUFoQm8mX3P5k 2pK6KBHEzfv7f+QpoVqGPIHuOALtdlQeyh+ETb/AnzHVNzChsUjxe8hU7xzsEZg= =w3VC -----END PGP SIGNATURE----- --Ug1PnspJTmFjg6tm1pS0xKCHfvdD1TCG0--