From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33196) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afVR6-00008B-Sd for qemu-devel@nongnu.org; Mon, 14 Mar 2016 12:33:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1afVR3-0007Y9-0C for qemu-devel@nongnu.org; Mon, 14 Mar 2016 12:33:40 -0400 Received: from mail-wm0-x236.google.com ([2a00:1450:400c:c09::236]:38827) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afVR2-0007Xu-P5 for qemu-devel@nongnu.org; Mon, 14 Mar 2016 12:33:36 -0400 Received: by mail-wm0-x236.google.com with SMTP id l68so110455777wml.1 for ; Mon, 14 Mar 2016 09:33:36 -0700 (PDT) Sender: Paolo Bonzini References: <1457972631-1376-1-git-send-email-minyard@acm.org> From: Paolo Bonzini Message-ID: <56E6E7DE.1040208@redhat.com> Date: Mon, 14 Mar 2016 17:33:34 +0100 MIME-Version: 1.0 In-Reply-To: <1457972631-1376-1-git-send-email-minyard@acm.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Sort the fw_cfg file list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: minyard@acm.org, qemu-devel@nongnu.org, "Michael S. Tsirkin" Cc: Corey Minyard , Gerd Hoffmann On 14/03/2016 17:23, minyard@acm.org wrote: > From: Gerd Hoffmann > > Entries are inserted at the correct place instead of being > appended to the end in case sorting is enabled. > > Signed-off-by: Gerd Hoffmann > > Added a new machine type for compatibility. > > Signed-off-by: Corey Minyard > --- > > I don't really like the double-negative created by dont_sort_fw_cfgs, > but it seems more consistent with the other fields (no_floppy, etc.) > where the default is 0 and the compat is 1. You can use the 2.6 machine type too. Paolo