From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35491) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afVXx-0005k5-Hd for qemu-devel@nongnu.org; Mon, 14 Mar 2016 12:40:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1afVXt-0001DH-8b for qemu-devel@nongnu.org; Mon, 14 Mar 2016 12:40:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33729) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afVXt-0001D5-3F for qemu-devel@nongnu.org; Mon, 14 Mar 2016 12:40:41 -0400 References: <1457954501-26528-1-git-send-email-den@openvz.org> <1457954501-26528-7-git-send-email-den@openvz.org> <56E6CBD1.2060509@redhat.com> <20160314143857.GE21198@redhat.com> <56E6D323.5080803@openvz.org> <20160314152604.GG21198@redhat.com> <20160314161153.GH21198@redhat.com> <56E6E3DB.2060109@openvz.org> From: Paolo Bonzini Message-ID: <56E6E984.1030000@redhat.com> Date: Mon, 14 Mar 2016 17:40:36 +0100 MIME-Version: 1.0 In-Reply-To: <56E6E3DB.2060109@openvz.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 6/9] log: log QMP commands and replies List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" , "Daniel P. Berrange" Cc: Markus Armbruster , Luiz Capitulino , qemu-devel@nongnu.org, Stefan Hajnoczi , Pavel Butsykin On 14/03/2016 17:16, Denis V. Lunev wrote: >> BTW, I'm not against adding this to QEMU in general - just pointing out >> that in the context of libvirt usage reference in the commit message, >> it is not really needed. I'm totally ambivalent wrt adding this to QEMU >> for benefit of non-libvirt usage. > > I see. This just requires very clear commit message from my side. > Thank you for a discussion. I think this is not a compelling usage of the logging subsystem; QMP is always used through a character device, and character devices already have a logging mechanism. Adding a mechanism that looks for '\n' in the data written to a character device and emits a timestamp on the next character would be a useful addition. I'd be entirely happy with adding it now, it should be safe enough that we can do it during soft freeze. Paolo