From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39480) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afVmM-0006YT-0I for qemu-devel@nongnu.org; Mon, 14 Mar 2016 12:55:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1afVmL-0004Zz-6O for qemu-devel@nongnu.org; Mon, 14 Mar 2016 12:55:37 -0400 References: <1457454872-12183-1-git-send-email-kwolf@redhat.com> <20160314113141.GA4812@noname.redhat.com> From: Max Reitz Message-ID: <56E6ED01.3080800@redhat.com> Date: Mon, 14 Mar 2016 17:55:29 +0100 MIME-Version: 1.0 In-Reply-To: <20160314113141.GA4812@noname.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="aCpO62l5hvHNc9v22ke2sGAd88iN83o71" Subject: Re: [Qemu-devel] [PATCH 00/11] block: Use BB function in .bdrv_create() implementations List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --aCpO62l5hvHNc9v22ke2sGAd88iN83o71 Content-Type: multipart/mixed; boundary="VajJlIaUCA10tpWU2rCXjpmVRRoxuEK4v" From: Max Reitz To: Kevin Wolf , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org Message-ID: <56E6ED01.3080800@redhat.com> Subject: Re: [Qemu-devel] [PATCH 00/11] block: Use BB function in .bdrv_create() implementations References: <1457454872-12183-1-git-send-email-kwolf@redhat.com> <20160314113141.GA4812@noname.redhat.com> In-Reply-To: <20160314113141.GA4812@noname.redhat.com> --VajJlIaUCA10tpWU2rCXjpmVRRoxuEK4v Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 14.03.2016 12:31, Kevin Wolf wrote: > Am 08.03.2016 um 17:34 hat Kevin Wolf geschrieben: >> All users of the block layers are supposed to go through a BlockBacken= d. >> The .bdrv_create() implementations are such users, so this series >> converts them. >> >> This series (specifically patch 1) will also help with moving the >> writethrough cache implementation from BDS to BB, where it really >> belongs. Once this is moved, it wouldn't be possible to use bdrv_open(= ) >> to use a standalone BDS writethrough any more. >> >> Of course, writethrough doesn't make any sense in .bdrv_create() anywa= y, >> so while I'm still converting everything to BB where it would keep >> working (because that's the Right Thing), the drivers don't actually >> make use of this fact any more after this series. >=20 > Applied to the block branch. Now you can't name any BB "image" any more if you want to use e.g. drive-mirror. Intended? Example: $ x86_64-softmmu/qemu-system-x86_64 -drive if=3Dnone,id=3Dimage,file=3Dnull-co://,driver=3Draw -qmp stdio {'execute':'qmp_capabilities'} {"return": {}} {'execute':'drive-mirror','arguments':{'device':'image','target':'foo.qco= w2','sync':'full','format':'qcow2'}} Formatting 'foo.qcow2', fmt=3Dqcow2 size=3D1073741824 encryption=3Doff cluster_size=3D65536 lazy_refcounts=3Doff refcount_bits=3D16 {"error": {"class": "GenericError", "desc": "Device with id 'image' already exists"}} Max --VajJlIaUCA10tpWU2rCXjpmVRRoxuEK4v-- --aCpO62l5hvHNc9v22ke2sGAd88iN83o71 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJW5u0BAAoJEDuxQgLoOKytBeEH/Rp9bQ5swSzaI4xf8oQiC7eW ifVa6IrZhRTzjepcxYInGFoLkbE8dNHRc/Q6DYq1uAywO7dymEki3DdX/CvIVdit fQHJBs9b4k4PNYeNeW2Ol5F4D8XH03dbFkpO5UX+vSiY7aIsuSN0hDmgQrcXTI69 J+ksmzuNScjhRqC6Rxh31yy/J6Iifie6oN7HQPOMP3FzyXfiG+wa64r7MsrhIvfj UIGBpkcgHiCZIF8nMxs6MslSPxcDnPiLIBMTVsqUKkUxfesPvy+i6k7Jeqh3BC0r JpAaHMiFqM52u0a/aKpObq9uN8b5R5xC2+Hv2WKl6HDO5z/QB5F0j0JPsc120MY= =hNkE -----END PGP SIGNATURE----- --aCpO62l5hvHNc9v22ke2sGAd88iN83o71--