From: Stefan Weil <sw@weilnetz.de>
To: Markus Armbruster <armbru@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Peter Crosthwaite <crosthwaite.peter@gmail.com>,
QEMU Developer <qemu-devel@nongnu.org>,
Andrew Baumann <Andrew.Baumann@microsoft.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH] Include setjmp.h in qemu/osdep.h (bug fix for w64)
Date: Mon, 14 Mar 2016 19:19:54 +0100 [thread overview]
Message-ID: <56E700CA.40406@weilnetz.de> (raw)
In-Reply-To: <8760wph78l.fsf@blackfin.pond.sub.org>
[-- Attachment #1: Type: text/plain, Size: 827 bytes --]
Am 14.03.2016 um 08:02 schrieb Markus Armbruster:
> Stefan Weil <sw@weilnetz.de> writes:
[...]
>> diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h
>> index 4538fdc..5bb374c 100644
>> --- a/include/qemu/osdep.h
>> +++ b/include/qemu/osdep.h
>> @@ -76,6 +76,9 @@ extern int daemon(int, int);
>> #include <sys/stat.h>
>> #include <sys/time.h>
>> #include <assert.h>
>> +/* setjmp must be declared before sysemu/os-win32.h
>> + * because it is redefined there. */
>> +#include <setjmp.h>
>> #include <signal.h>
>>
>> #ifdef __OpenBSD__
>
> Please add <setjmp.h> to scripts/clean-includes.
>
Thanks for this hint. I had already prepared a patch
which removes the now unneeded setjmp.h include statements
and added the modification for scripts/clean-includes
to that patch now.
Stefan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-03-14 18:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-12 6:31 [Qemu-devel] [PATCH] Include setjmp.h in qemu/osdep.h (bug fix for w64) Stefan Weil
2016-03-12 20:54 ` Richard Henderson
2016-03-14 7:02 ` Markus Armbruster
2016-03-14 18:19 ` Stefan Weil [this message]
2016-03-14 18:21 ` Andrew Baumann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E700CA.40406@weilnetz.de \
--to=sw@weilnetz.de \
--cc=Andrew.Baumann@microsoft.com \
--cc=armbru@redhat.com \
--cc=crosthwaite.peter@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).